tests: rm HSM availability assertion in tox.ini #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, tox asserts that PYKCS11LIB env var is set to not silently skip tests on SoftHSM (virtual HSM). This is is unnecessary for CI, where we control the env var, and also hard to figure out locally, where we can't expect everyone to setup SoftHSM. This patch removes the assertion and adds a note to ci.yml to point out the consequences of unsetting the env var. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, tox asserts that PYKCS11LIB env var is set to not silently skip tests on SoftHSM (virtual HSM).
This is is unnecessary for CI, where we control the env var, and also hard to figure out locally, where we can't expect everyone to setup SoftHSM.
This patch removes the assertion and adds a note to ci.yml to point out the consequences of unsetting the env var.
Fixes #527