tests: quickfix flaky error message assertion #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every now and then this test fails, because pyca/cryptography raises an unexpected error message (see pyca/cryptography#8563) Regardless of whether it is a good idea to assert error messages of 3rd party libraries, this patch provides a quick fix by asserting that is one of both known error messages. closes secure-systems-lab#463 Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
jku
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every now and then this test fails, because pyca/cryptography raises an unexpected error message (see pyca/cryptography#8563)
Regardless of whether it is a good idea to assert error messages of 3rd party libraries, this patch provides a quick fix by asserting that it is one of both known error messages.
closes #463