signer API: improve graceful failure testing and fix thus revealed error handling bug #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make test table driven to easily add other Key implementations. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Key.verify_signature implementations should only raise UnverifiedSignatureError or VerificationError, even if an optional dependency is missing. This commit changes SSlibKey.verify_signature to re-raise UnsupportedLibrarError as VerificationError. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Test SSlibKey and SigstoreKey in addition to already tested GPGKey. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
lukpueh
force-pushed
the
improve-key-checks
branch
from
b7ad98d
to
b1cf437
Compare
lukpueh
requested review from
jku and
adityasaky
and removed request for
adityasaky
jku
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve tests on runner that don't have extra dependencies installed:
Fix SSlibKey.verify_signature to re-raise UnsupportedLibraryError as VerificationError