SigstoreSigner: Use sigstore 1.1.2 #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 1.1.2 has an accidental API change that makes it incompatible with lower versions * This change is reverted in next release, but next release has planned API breaks * sigstore 1.1.1 has an unrelated bug that means it does not really work with current sigstore infrastructure (the current TUF repository to be exact) So plan is: 1. Pin 1.1.2: it's the only version that works right now 2. Upgrade to 2.0.0 once it comes out: this will require small code changes This commit handles part 1.
lukpueh
approved these changes
May 24, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So plan is:
This commit handles part 1.
Test run:
https://github.com/secure-systems-lab/securesystemslib/actions/runs/5065716114/jobs/9094614085
Please verify and check that the pull request fulfils the following requirements: