Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Azure Signer support #588

Merged
merged 41 commits into from
Jun 1, 2023
Merged

Add Azure Signer support #588

merged 41 commits into from
Jun 1, 2023

Commits on May 24, 2023

  1. start adding azure signer implementation 

    Signed-off-by: Meredith Lancaster <malancas@github.com>
    @malancas
    malancas committed May 24, 2023
    Configuration menu
    Copy the full SHA
    f6ffa19 View commit details
    Browse the repository at this point in the history

  2. Added packages to requirements and a small bug fix 

    Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
    @kommendorkapten
    kommendorkapten committed May 24, 2023
    Configuration menu
    Copy the full SHA
    618b4de View commit details
    Browse the repository at this point in the history

  3. Removed debub print 

    Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
    @kommendorkapten
    kommendorkapten committed May 24, 2023
    Configuration menu
    Copy the full SHA
    a5317d1 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #1 from kommendorkapten/fixes 

    Added packages to requirements and a small bug fix
    @malancas
    malancas authored May 24, 2023
    Configuration menu
    Copy the full SHA
    1502d94 View commit details
    Browse the repository at this point in the history

  5. Added missing imports 

    Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
    @kommendorkapten
    kommendorkapten committed May 24, 2023
    Configuration menu
    Copy the full SHA
    c88c7f9 View commit details
    Browse the repository at this point in the history

  6. Use the keyvault uri

    @kommendorkapten
    kommendorkapten committed May 24, 2023
    Configuration menu
    Copy the full SHA
    ba237b8 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #2 from kommendorkapten/fix_imports2 

    Added missing imports
    @malancas
    malancas authored May 24, 2023
    Configuration menu
    Copy the full SHA
    90f15a4 View commit details
    Browse the repository at this point in the history

  8. replace match with if else 

    Signed-off-by: Meredith Lancaster <malancas@github.com>
    @malancas
    malancas committed May 24, 2023
    Configuration menu
    Copy the full SHA
    8fe44e7 View commit details
    Browse the repository at this point in the history

  9. working signer creation and signing 

    Signed-off-by: Meredith Lancaster <malancas@github.com>
    @malancas
    malancas committed May 24, 2023
    Configuration menu
    Copy the full SHA
    3239a7e View commit details
    Browse the repository at this point in the history

  10. clean up functions 

    Signed-off-by: Meredith Lancaster <malancas@github.com>
    @malancas
    malancas committed May 24, 2023
    Configuration menu
    Copy the full SHA
    d7437bd View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Make sure to calculated the digest using the correct hash function. 

    The CryptographySigner expectes the digest when it performs a signing
operation. It's a nicer API to let the AzureSigner calculate the digest.
    @kommendorkapten
    kommendorkapten committed May 25, 2023
    Configuration menu
    Copy the full SHA
    df9b5c2 View commit details
    Browse the repository at this point in the history

  2. Make sure signature is in ASN.1 format 

    Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
    @kommendorkapten
    kommendorkapten committed May 25, 2023
    Configuration menu
    Copy the full SHA
    a820bcf View commit details
    Browse the repository at this point in the history

  3. Merge pull request #4 from kommendorkapten/sign_digest 

    Make sure to calculated the digest using the correct hash function.
    @malancas
    malancas authored May 25, 2023
    Configuration menu
    Copy the full SHA
    942a229 View commit details
    Browse the repository at this point in the history

  4. add comments and exceptions around only supporting ec keys 

    Signed-off-by: Meredith Lancaster <malancas@github.com>
    @malancas
    malancas committed May 25, 2023
    Configuration menu
    Copy the full SHA
    041be38 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Added an import method with returns the public key in the expected fo… 

    …rmat.

Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
    @kommendorkapten
    kommendorkapten committed May 26, 2023
    Configuration menu
    Copy the full SHA
    473648c View commit details
    Browse the repository at this point in the history

  2. Updated comment to be correct on second ctor parameter 

    Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
    @kommendorkapten
    kommendorkapten committed May 26, 2023
    Configuration menu
    Copy the full SHA
    41a89ae View commit details
    Browse the repository at this point in the history

  3. Merge pull request #5 from kommendorkapten/add_import_method 

    Add import method
    @malancas
    malancas authored May 26, 2023
    Configuration menu
    Copy the full SHA
    ca0dad4 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into add-azure-support

    @malancas
    malancas committed May 26, 2023
    Configuration menu
    Copy the full SHA
    1ac6bc9 View commit details
    Browse the repository at this point in the history

  5. remove extra staticmethod 

    Signed-off-by: Meredith Lancaster <malancas@github.com>
    @malancas
    malancas committed May 26, 2023
    Configuration menu
    Copy the full SHA
    4184d0b View commit details
    Browse the repository at this point in the history

  6. move cryptography imports 

    Signed-off-by: Meredith Lancaster <malancas@github.com>
    @malancas
    malancas committed May 26, 2023
    Configuration menu
    Copy the full SHA
    f2c354f View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. lint: Run black and isort 

    Specifically
$ black .
$ isort .
    @jku
    jku committed May 29, 2023
    Configuration menu
    Copy the full SHA
    fe326b0 View commit details
    Browse the repository at this point in the history

  2. AzureSigner: Fix a bunch of lint issues 

    These are the trivial looking issues: there are still some left that
require actual decisions (both in pylint and mypy)
    @jku
    jku committed May 29, 2023
    Configuration menu
    Copy the full SHA
    a692a5e View commit details
    Browse the repository at this point in the history

  3. AzureSigner: Use "stringized" annotations where needed 

    To allow the _azure_signer module import when azure dependency modules
are not installed, use stringized annotations (this allows method
definitions to happen without the types existing, while still letting
the static type checkers do their work).
    @jku
    jku committed May 29, 2023
    Configuration menu
    Copy the full SHA
    fa4f443 View commit details
    Browse the repository at this point in the history

  4. Cleaned up the usage of uris. 

    It's clear now wheter it's a private uri (azurekms) or an azure uri (https)

Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
    @kommendorkapten
    kommendorkapten committed May 29, 2023
    Configuration menu
    Copy the full SHA
    64a536e View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Merge pull request #8 from kommendorkapten/uri_fixes 

    Cleaned up the usage of uris.
    @malancas
    malancas authored May 30, 2023
    Configuration menu
    Copy the full SHA
    4272655 View commit details
    Browse the repository at this point in the history

  2. remove test runner 

    Signed-off-by: Meredith Lancaster <malancas@github.com>
    @malancas
    malancas committed May 30, 2023
    Configuration menu
    Copy the full SHA
    d6e60b6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'add-azure-support' of github.com:malancas/securesystems… 

    …lib into add-azure-support
    @malancas
    malancas committed May 30, 2023
    Configuration menu
    Copy the full SHA
    a702b39 View commit details
    Browse the repository at this point in the history

  4. Update the import method to return a key id that contains the version… 

    … too

Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
    @kommendorkapten
    kommendorkapten committed May 30, 2023
    Configuration menu
    Copy the full SHA
    80bf9a2 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #9 from kommendorkapten/az_use_key_ver 

    Update the import method to return a key id that contains the version…
    @malancas
    malancas authored May 30, 2023
    Configuration menu
    Copy the full SHA
    8fb25cc View commit details
    Browse the repository at this point in the history

  6. fix linting issues 

    Signed-off-by: Meredith Lancaster <malancas@github.com>
    @malancas
    malancas committed May 30, 2023
    Configuration menu
    Copy the full SHA
    9232e44 View commit details
    Browse the repository at this point in the history

  7. linter fix, raise error after logging 

    Signed-off-by: Meredith Lancaster <malancas@github.com>
    @malancas
    malancas committed May 30, 2023
    Configuration menu
    Copy the full SHA
    960b741 View commit details
    Browse the repository at this point in the history

  8. add docstrings 

    Signed-off-by: Meredith Lancaster <malancas@github.com>
    @malancas
    malancas committed May 30, 2023
    Configuration menu
    Copy the full SHA
    688555e View commit details
    Browse the repository at this point in the history

  9. add pylint disable comment for too-many-locals 

    Signed-off-by: Meredith Lancaster <malancas@github.com>
    @malancas
    malancas committed May 30, 2023
    Configuration menu
    Copy the full SHA
    c00d3df View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Support all EC keys, not just HSM 

    Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
    @kommendorkapten
    kommendorkapten committed May 31, 2023
    Configuration menu
    Copy the full SHA
    3c99967 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #10 from kommendorkapten/all_ec_keys

    @malancas
    malancas authored May 31, 2023
    Configuration menu
    Copy the full SHA
    b17370e View commit details
    Browse the repository at this point in the history

  3. More actionable error message 

    Co-authored-by: Jussi Kukkonen <jku@goto.fi>
    @malancas @jku
    malancas and jku authored May 31, 2023
    Configuration menu
    Copy the full SHA
    2d7c05b View commit details
    Browse the repository at this point in the history

  4. pr feedback, don't need to stringify Key 

    Signed-off-by: Meredith Lancaster <malancas@github.com>
    @malancas
    malancas committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f540090 View commit details
    Browse the repository at this point in the history

  5. pr feedback, add section with roles needed by the azure signer, simpl… 

    …ify signature creation

Signed-off-by: Meredith Lancaster <malancas@github.com>
    @malancas
    malancas committed May 31, 2023
    Configuration menu
    Copy the full SHA
    e905b27 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Fixed a bug that sets the wrong key id on the returned signature. 

    Added smoke tests for Azure KMS sign.

Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
    @kommendorkapten
    kommendorkapten committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    ca60489 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #11 from kommendorkapten/correct_key_id

    @malancas
    malancas authored Jun 1, 2023
    Configuration menu
    Copy the full SHA
    eeabc68 View commit details
    Browse the repository at this point in the history

  3. requirements-kms: Remove azure packages 

    requirements-kms.txt lists the requirements to run
tests.check_kms_signers (which is run on CI): Azure is not currently
part of that test set so the requirements are not needed either.
    @jku
    jku committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    36b65a4 View commit details
    Browse the repository at this point in the history