Unbalanced dataset splits #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling openfl develop changes
Rename tensorboard option Co-authored-by: Ilya Trushkin <76161256+itrushkin@users.noreply.github.com>
If we dont define this callback in notebook it will be taken from workspace, if exists
Pulling changes from the main repo
It's necessary for logger to parse this tag
Collaborator logs metric task result, but sometimes collaborator and aggregator have different consoles (in interactive api e.g.)
igor-davidyuk
suggested changes
Aug 3, 2021
| enforce_image_hw: str = None) -> None: | ||
| """Initialize KvasirShardDescriptor.""" | ||
| super().__init__() | ||
| class KvasirDataset(Dataset): |
There was a problem hiding this comment.
There is no need in pytorch dataset here. I suggest removing all pytorch mentions
|
|
||
| # Sharding | ||
| shard_idx = data_splitter.split(labels, self.world_size)[self.rank] | ||
| self.shard = Subset(dataset, shard_idx) |
There was a problem hiding this comment.
this line could be just
self.images_names = [self.images_names[i] for i in shard_idx]
| """ | ||
| self.shuffle = shuffle | ||
|
|
||
| def split(self, labels, num_collaborators): |
There was a problem hiding this comment.
seems like the signature is changed in this subclass
aleksandr-mokrov
approved these changes
Aug 13, 2021
|
Jenkins please retry a build |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a data splitting interface with the following implementations: