-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flake8 extensions to linter CI workflow #560
Conversation
New flake8 rules have been applied. I will convert this to a draft and fix all the issues here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
One thing that I would do is separate this into two PRs.
One will contain changes to CI and another one with linter highlited fixes.
@igor-davidyuk It seems that CI changes affect GitHub actions immediately. I had linter errors after enabling the extensions, thus I had to fix them in the same pull request. |
Yeah, I thought it was the case. We could Merge a PR with fixes first to avoid this problem 🤣 |
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
aeea70e
to
4c548ab
Compare
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
This pull request contains:
Tested the behavior locally via act.