-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the code snippet included in the issue and refactored how the code snippet is printed #497
Extend the code snippet included in the issue and refactored how the code snippet is printed #497
Conversation
…code snippet is printed Signed-off-by: Cosmin Cojocar <cosmin.cojocar@gmx.ch>
Signed-off-by: Cosmin Cojocar <cosmin.cojocar@gmx.ch>
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
==========================================
+ Coverage 71.75% 72.70% +0.94%
==========================================
Files 9 9
Lines 662 674 +12
==========================================
+ Hits 475 490 +15
+ Misses 164 163 -1
+ Partials 23 21 -2
Continue to review full report at Codecov.
|
Signed-off-by: Cosmin Cojocar <cosmin.cojocar@gmx.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
(I didn't check if this caused any issues with other output formatters though)
on other format it generates something like this:
|
3 lines are taken from the code snippet and inclined with the line numbers. |
fixes #268
This will capture 3 lines around the place where the issue occurs. The output looks something like:
Also it marks properly a multiline finding:
In this way, it seems easier to figure out the place where the security issue is detected.