Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo renderers to be extensions entry_points #541

Closed
ericwb opened this issue Jul 29, 2024 · 0 comments · Fixed by #542
Closed

Redo renderers to be extensions entry_points #541

ericwb opened this issue Jul 29, 2024 · 0 comments · Fixed by #542
Labels
enhancement New feature or request

Comments

@ericwb
Copy link
Contributor

ericwb commented Jul 29, 2024

Is your feature request related to a problem? Please describe.
Similar to the parsers and rules, the renderers deserve to also be extensions.

Describe the solution you'd like
Define renderers in setup.cfg as an extensions entry_points.

Describe alternatives you've considered
Currently hard-coded.

Additional context
n/a

Love this idea? Give it a 👍. We prioritize fulfilling features with the most 👍.

@ericwb ericwb added the enhancement New feature or request label Jul 29, 2024
ericwb added a commit to ericwb/precli that referenced this issue Jul 29, 2024
The renderers should ideally be loaded via the extension mechanism
rather than hard-coding the load of each class.

This also enables the ability to add future renderers without
changes to the code that loads them.

Closes securesauce#541

Signed-off-by: Eric Brown <eric.brown@securesauce.dev>
ericwb added a commit that referenced this issue Jul 29, 2024
The renderers should ideally be loaded via the extension mechanism
rather than hard-coding the load of each class.

This also enables the ability to add future renderers without changes to
the code that loads them.

Closes #541

Signed-off-by: Eric Brown <eric.brown@securesauce.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant