Fix traceback when not passing file to -o option #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If precli-init is run without an argument for the -o, it will fail with a traceback due to the argparse.FileType not allowing a default of a str for a file name. This change does the logic of detecting and opening files manually on its own. It will present an error if the file already exists to prevent overwriting. Except in the case where the file is pyproject.toml and the settings will be appended to it. Signed-off-by: Eric Brown <eric.brown@securesauce.dev>
ericwb
force-pushed
the
precli-init_output
branch
from
362dfe0 to
dc9eedf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If precli-init is run without an argument for the -o, it will fail with a traceback due to the argparse.FileType not allowing a default of a str for a file name.
This change does the logic of detecting and opening files manually on its own. It will present an error if the file already exists to prevent overwriting. Except in the case where the file is pyproject.toml and the settings will be appended to it.