chore: create a single CLI download image #227
Conversation
The Konflux team has made changes to the build-source-image task, which previously failed when adding more than just cosign, gitsign and rekor-cli to the image. When we added ec to it, the task began to fail due to an overly large results string, which Konflux could not handle. That limitation in Konflux has been eliminated. The change in this commit is to create a single CLI download image, which can be used by the operator, instead of the multiple currently in place. Once this change is committed on the main branch, a new component can be created in Konflux to test the build. If it is successful, we can remove the following components from the `cli` Application in Konflux, and subsequently remove those Dockerfiles from this repo. The following components can be removed after this build is successful. * cli/client-server-cg * cli/client-server-ec * cli/client-server-f Signed-off-by: Lance Ball <lball@redhat.com>
|
With this are we planning on using this image to server the binary's via Apache? As in adding a web server to this image. Currently we copy these images into a web server via init containers, where as before we had to do this, this image would have included the web server. If we decide to add the web server to this image, I believe the binary's need to be placed on a specific path to be server correctly |
Instead of having the operator provide the httpd server, include it here to simplify cluster deployment. Signed-off-by: Lance Ball <lball@redhat.com>
|
@JasonPowr I've modified this image to include the httpd server and placed the binaries in /var/www/html. PTAL |
Signed-off-by: Lance Ball <lball@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JasonPowr, lance The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Konflux team has made changes to the build-source-image task, which previously failed when adding more than just cosign, gitsign and rekor-cli to the image. When we added ec to it, the task began to fail due to an overly large results string, which Konflux could not handle. That limitation in Konflux has been eliminated.
The change in this commit is to create a single CLI download image, which can be used by the operator, instead of the multiple currently in place. Once this change is committed on the main branch, a new component can be created in Konflux to test the build. If it is successful, we can remove the following components from the
cliApplication in Konflux, and subsequently remove those Dockerfiles from this repo.The following components can be removed after this build is successful.