unit tests use tas pipeline #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janine Olear <pninak@web.de>
miyunari
force-pushed
the
unit_tests_on_tas_pipeline_v2
branch
from
4fef38c to
ae7b441
Compare
JasonPowr
requested changes
Aug 29, 2024
Signed-off-by: Janine Olear <pninak@web.de>
Perfect, thanks a lot! I adressed everything you found 👍 |
Signed-off-by: Janine Olear <pninak@web.de>
Signed-off-by: Nina <54885993+miyunari@users.noreply.github.com>
miyunari
force-pushed
the
unit_tests_on_tas_pipeline_v2
branch
2 times, most recently
from
b630fc9 to
31803ae
Compare
It now accepts individual suffixes, e.g.: - go1.21.9 - go1.22.3 (Red Hat 1.21.9-2.el9_4) Signed-off-by: Janine Olear <pninak@web.de>
miyunari
force-pushed
the
unit_tests_on_tas_pipeline_v2
branch
2 times, most recently
from
40417b0 to
0f8fb7e
Compare
miyunari
force-pushed
the
unit_tests_on_tas_pipeline_v2
branch
from
0f8fb7e to
fa02558
Compare
Signed-off-by: Janine Olear <pninak@web.de>
miyunari
force-pushed
the
unit_tests_on_tas_pipeline_v2
branch
from
fa02558 to
7cf043e
Compare
|
/retest |
1 similar comment
|
/retest |
|
@JasonPowr, could you review the PR again? :) I think all the remaining issues seen in the ci-pipeline are not related to my work - wdyt? :) |
Signed-off-by: Janine Olear <pninak@web.de>
miyunari
force-pushed
the
unit_tests_on_tas_pipeline_v2
branch
from
66f3906 to
ec6b71c
Compare
Signed-off-by: Nina <54885993+miyunari@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JasonPowr, miyunari The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.