-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use released version of EC image #256
Conversation
Now that the EC image goes through a proper release process, let's use that instead of using the latest built image. Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@simonbaird: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lcarva, simonbaird The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FYI, we'll probably update to a 0.5 build in the near future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
=======================================
Coverage ? 37.05%
=======================================
Files ? 203
Lines ? 12782
Branches ? 0
=======================================
Hits ? 4737
Misses ? 7455
Partials ? 590 ☔ View full report in Codecov by Sentry. |
I think this needs an |
/retest |
Now that the EC image goes through a proper release process, let's use that instead of using the latest built image.