Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use released version of EC image #256

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

lcarva
Copy link

@lcarva lcarva commented Sep 10, 2024

Now that the EC image goes through a proper release process, let's use that instead of using the latest built image.

Now that the EC image goes through a proper release process, let's use
that instead of using the latest built image.

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
Copy link

openshift-ci bot commented Sep 10, 2024

@simonbaird: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lcarva, simonbaird

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonbaird
Copy link

FYI, we'll probably update to a 0.5 build in the near future.

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@237af8a). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage        ?   37.05%           
=======================================
  Files           ?      203           
  Lines           ?    12782           
  Branches        ?        0           
=======================================
  Hits            ?     4737           
  Misses          ?     7455           
  Partials        ?      590           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lcarva
Copy link
Author

lcarva commented Sep 11, 2024

I think this needs an /ok-to-test comment. The CI-Tests and golingci-lint failures seem to be unrelated.

@lance
Copy link
Member

lance commented Sep 11, 2024

/retest

@lance lance merged commit 8abdd7e into securesign:main Sep 11, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants