Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Dockerfile for backfill-redis #53

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

lance
Copy link
Member

@lance lance commented Sep 15, 2023

This commit adds a Dockerfile for building a backfill-redis image, which should be used periodically to ensure that redis contains the complete rekor log.

The patchfile is required due to this upstream issue:

sigstore#1685

Once that pull request has been merged, we'll need to remove the patchfile from main but not from the midstream-v1.2.2 branch unless it is backported upstream.

/cherry-pick midstream-v1.2.2

This commit adds a Dockerfile for building a `backfill-redis` image,
which should be used periodically to ensure that redis contains the
complete rekor log.

The patchfile is required due to this upstream issue:

sigstore#1685

Once that pull request has been merged, we'll need to remove the
patchfile from `main` but not from the `midstream-v1.2.2` branch unless
it is backported upstream.

Signed-off-by: Lance Ball <lball@redhat.com>
Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, RobotSail

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance lance merged commit d37abb1 into securesign:main Sep 15, 2023
lance added a commit that referenced this pull request Sep 15, 2023
This commit adds a Dockerfile for building a `backfill-redis` image,
which should be used periodically to ensure that redis contains the
complete rekor log.

The patchfile is required due to this upstream issue:

sigstore#1685

Once that pull request has been merged, we'll need to remove the
patchfile from `main` but not from the `midstream-v1.2.2` branch unless
it is backported upstream.

/cherry-pick midstream-v1.2.2

Signed-off-by: Lance Ball <lball@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants