Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizing build conditions to reduce RHTAP workloads #148

Merged

Conversation

Gregory-Pereira
Copy link

/cc @lance @tommyd450
This a version of #112 but for branch redhat-v0.6

@openshift-ci openshift-ci bot requested review from lance and tommyd450 November 28, 2023 21:41
@Gregory-Pereira Gregory-Pereira force-pushed the redhat-v0.6-optimize-builds branch from 2e6e9a8 to fae7341 Compare November 29, 2023 21:28
@Gregory-Pereira
Copy link
Author

bump @lance @tommyd450. I feel that resource utilization is the greatest issue were dealing with respect to RHTAP its a pretty limiting factor. Very nervous to test things with regard to EC because it would rebuild every other component.

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Can you add these changes to the createctconfig-*.yaml files, and correct the createcerts-*.yaml file.

.tekton/cloudsqlproxy-0-6-pull-request.yaml Outdated Show resolved Hide resolved
.tekton/createcerts-1-0-gamma-pull-request.yaml Outdated Show resolved Hide resolved
.tekton/createcerts-1-0-gamma-push.yaml Outdated Show resolved Hide resolved
.tekton/ct-server-0-6-pull-request.yaml Outdated Show resolved Hide resolved
fixing create-certs cel references

Co-authored-by: Lance Ball <lball@redhat.com>
Signed-off-by: Gregory Pereira <gregpere17@gmail.com>
@Gregory-Pereira Gregory-Pereira force-pushed the redhat-v0.6-optimize-builds branch from 4e8118a to 7aa1786 Compare November 30, 2023 18:39
Copy link

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gregory-Pereira, lance

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance lance merged commit 4533698 into securesign:redhat-v0.6 Nov 30, 2023
11 of 18 checks passed
tommyd450 pushed a commit to tommyd450/scaffolding that referenced this pull request Jun 5, 2024
* optimizing build conditions to reduce RHTAP workloads

* Apply suggestions from code review

fixing create-certs cel references

Co-authored-by: Lance Ball <lball@redhat.com>
Signed-off-by: Gregory Pereira <gregpere17@gmail.com>

---------

Signed-off-by: Gregory Pereira <gregpere17@gmail.com>
Co-authored-by: Lance Ball <lball@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants