Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURESIGN-336] chore: remove cloudsqlproxy builds #168

Merged

Conversation

lance
Copy link
Member

@lance lance commented Dec 1, 2023

I've left the source code in. There seems to be no compelling reason to remove it, other than cleanliness, and it's kind of nice to have the repo as close to upstream as possible.

I've left the source code in. There seems to be no compelling reason to
remove it, other than cleanliness, and it's kind of nice to have the
repo as close to upstream as possible.

Signed-off-by: Lance Ball <lball@redhat.com>
Copy link

@JasonPowr JasonPowr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JasonPowr, lance, tommyd450

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance lance merged commit 081e1de into securesign:redhat-v0.6 Dec 1, 2023
5 of 8 checks passed
tommyd450 pushed a commit to tommyd450/scaffolding that referenced this pull request Jun 5, 2024
I've left the source code in. There seems to be no compelling reason to
remove it, other than cleanliness, and it's kind of nice to have the
repo as close to upstream as possible.

Signed-off-by: Lance Ball <lball@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants