Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): add rekor endpoint env var #205

Merged
merged 2 commits into from
Mar 19, 2024
Merged

feat(config): add rekor endpoint env var #205

merged 2 commits into from
Mar 19, 2024

Conversation

kahboom
Copy link
Contributor

@kahboom kahboom commented Mar 15, 2024 •
edited
Loading

This PR adds the required environment variable in order for the rekor-search-ui to be able to issue requests to the Rekor server.

Original PR: #204

Testing with the following container image for the rekor search UI: quay.io/kahboom/rekor-search-ui@sha256:68a21610cd7de9c34466fed181fb3b26e527906e194f90657ab3c785b2151c85

Instructions for testing: https://gist.github.com/kahboom/3294d64b5186b3c79b68bd78923ebec5

@openshift-ci openshift-ci bot requested review from JasonPowr and tommyd450 March 15, 2024 20:11
@kahboom kahboom changed the title feat(config): add reference rekor ui env var feat(config): add rekor endpoint env var Mar 15, 2024
@kahboom
Copy link
Contributor Author

kahboom commented Mar 18, 2024

I've added some instructions for testing the PR, hopefully it helps as I didn't previously share the container image for rekor-search-ui I had been using (sorry!): https://gist.github.com/kahboom/3294d64b5186b3c79b68bd78923ebec5#file-sigstore-ocp-md

@kahboom
feat(config): add env var for rekor endpoint
84af1ea 
refactor(config): swap ConfigMap for global env values

Co-authored-by: Jason Power <japower@redhat.com>

ci(fix): run git pre-commit hook

fix: reset README.md
@JasonPowr
Copy link
Contributor

@kahboom The CI is currently failing with:

Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "sigstore" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading scaffold from repo https://sigstore.github.io/helm-charts
Deleting outdated charts
Linting chart "trusted-artifact-signer => (version: \"0.1.46\", path: \"charts/trusted-artifact-signer\")"
Checking chart "trusted-artifact-signer => (version: \"0.1.46\", path: \"charts/trusted-artifact-signer\")" for a version bump...
Old chart version: 0.1.46
New chart version: 0.1.46
Error: failed linting charts: failed processing charts

------------------------------------------------------------------------------------------------------------------------
 ✖︎ trusted-artifact-signer => (version: "0.1.46", path: "charts/trusted-artifact-signer") > chart version not ok. Needs a version bump! 
------------------------------------------------------------------------------------------------------------------------
failed linting charts: failed processing charts
Error: Process completed with exit code 1.

Any time there is a change to the helm chart we need to bump the chart version by one: https://github.com/securesign/sigstore-ocp/blob/main/charts/trusted-artifact-signer/Chart.yaml#L36
so this should become: version: 0.1.47

@JasonPowr
Copy link
Contributor

@kahboom The changes themselves seem fine, works well :), just that small issue with the chart version

JasonPowr
JasonPowr approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@JasonPowr JasonPowr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 19, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JasonPowr, kahboom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JasonPowr JasonPowr merged commit 4721f1f into main Mar 19, 2024
3 of 4 checks passed
@kahboom kahboom deleted the dev branch March 19, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonPowr JasonPowr JasonPowr approved these changes

@tommyd450 tommyd450 Awaiting requested review from tommyd450

Assignees

@JasonPowr JasonPowr

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kahboom @JasonPowr