feat(batching): Batching module with batch construction in end blocker #560
hacheigriegalint.yml
on: pull_request
golangci
1m 2s
protobuf
5s
Annotations
5 errors and 6 warnings
|
protobuf
Process completed with exit code 2.
|
|
golangci:
x/batching/keeper/abci.go#L78
Consider pre-allocating `dataLeaves` (prealloc)
|
|
golangci:
x/batching/keeper/abci.go#L88
S1008: should use 'return bytes.Compare(dataLeaves[i], dataLeaves[j]) == -1' instead of 'if bytes.Compare(dataLeaves[i], dataLeaves[j]) == -1 { return true }; return false' (gosimple)
|
|
golangci:
x/batching/keeper/abci.go#L114
S1008: should use 'return bytes.Compare(valLeaves[i], valLeaves[j]) == -1' instead of 'if bytes.Compare(valLeaves[i], valLeaves[j]) == -1 { return true }; return false' (gosimple)
|
|
golangci
issues found
|
|
protobuf
The following actions use a deprecated Node.js version and will be forced to run on node20: bufbuild/buf-setup-action@v1.26.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
protobuf
No github_token supplied, API requests will be subject to stricter rate limiting
|
|
golangci
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v4, golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
golangci
Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2
|
|
golangci:
x/batching/types/genesis.go#L21
unused-parameter: parameter 'gs' seems to be unused, consider removing or renaming it as _ (revive)
|
|
golangci:
x/pubkey/client/cli/tx.go#L54
unused-parameter: parameter 'args' seems to be unused, consider removing or renaming it as _ (revive)
|