feat(batching): Batching module with batch construction in end blocker #563
hacheigriegalint.yml
on: pull_request
golangci
3m 46s
protobuf
8s
Annotations
7 errors and 5 warnings
|
protobuf
Process completed with exit code 2.
|
|
golangci:
x/batching/keeper/abci.go#L137
Consider pre-allocating `leaves` (prealloc)
|
|
golangci:
x/batching/keeper/abci.go#L138
Consider pre-allocating `votes` (prealloc)
|
|
golangci:
x/pubkey/client/cli/tx.go#L167
unnecessary conversion (unconvert)
|
|
golangci:
x/pubkey/client/cli/tx.go#L181
unnecessary conversion (unconvert)
|
|
golangci:
x/batching/keeper/abci.go#L158
SA4010: this result of append is never used, except maybe in other appends (staticcheck)
|
|
golangci
issues found
|
|
protobuf
The following actions use a deprecated Node.js version and will be forced to run on node20: bufbuild/buf-setup-action@v1.26.1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
protobuf
No github_token supplied, API requests will be subject to stricter rate limiting
|
|
golangci
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v4, golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
golangci:
x/batching/types/genesis.go#L21
unused-parameter: parameter 'gs' seems to be unused, consider removing or renaming it as _ (revive)
|
|
golangci:
x/pubkey/client/cli/tx.go#L54
unused-parameter: parameter 'args' seems to be unused, consider removing or renaming it as _ (revive)
|