Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Use separate wasm types for data request and overlay wasms #309

Closed
hacheigriega opened this issue Jul 24, 2024 · 0 comments · Fixed by #311
Closed

♻️ Use separate wasm types for data request and overlay wasms #309

hacheigriega opened this issue Jul 24, 2024 · 0 comments · Fixed by #311
Labels
type: refactor ♻️ Code change that neither fixes a bug nor adds a feature

Comments

@hacheigriega
Copy link
Member

♻️ Refactor

Currently the module x/wasm-storage uses the same type Wasm for dealing with both data request wasms and overlay wasms. This design choice was originally made mainly to accommodate a wider variety of wasm types by using Wasm's WasmType field. Since this is no longer the case, it makes sense to create and use two different types DataRequestWasm and OverlayWasm with slightly different fields. The naming may also have to be reconsidered.
@hacheigriega hacheigriega added the type: refactor ♻️ Code change that neither fixes a bug nor adds a feature label Jul 24, 2024
@hacheigriega hacheigriega mentioned this issue Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: refactor ♻️ Code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Add tally module and refactor wasm types sedaprotocol/seda-chain
1 participant
@hacheigriega