refactor: Add tally module and refactor wasm types #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacheigriega
changed the title
Thomasvdam
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
We should be mindful that this includes breaking changes. Is there a way we can get Goreleaser to add this to the release notes?
Once merged the SEDA SDK will need to update the proto definitions and generate the implementation. I think the overlay is not affected, but we should double check :)
mariocao
approved these changes
Jul 30, 2024
hacheigriega
force-pushed
the
hy/tally-module
branch
from
3bfc1a4
to
3a14c1a
Compare
|
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR creates a new module
x/tallyto house the tally-related logic. Note that this module does not store any states.This PR creates two distinct wasm types
DataRequestWasmandExecutorWasm, where the former contains pruning-related fields and the latter does not. The enum-like fieldWasmType, which used to indicate the wasm type, has been removed.Explanation of Changes
The term "overlay" has been renamed to "executor."
Here is the list of API changes:
sedad query wasm-storage overlay-wasm <hash>->sedad query wasm-storage executor-wasm <hash>sedad query wasm-storage list-overlay-wasms->sedad query wasm-storage list-executor-wasmssedad tx wasm-storage submit-proposal store-overlay-wasm ...->sedad tx wasm-storage submit-proposal store-executor-wasm ...sedad tx wasm-storage submit-proposal instantiate-and-register-core-contract ...->sedad tx wasm-storage submit-proposal instantiate-core-contract ...GET /seda-chain/wasm-storage/overlay_wasms->GET /seda-chain/wasm-storage/executor_wasmsGET /seda-chain/wasm-storage/overlay_wasm/{hash}->GET /seda-chain/wasm-storage/executor_wasm/{hash}Related PRs and Issues
Closes: #309
Closes: #310