Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Gas estimation very off in pubkey module's add-seda-key tx #341

Closed
hacheigriega opened this issue Aug 23, 2024 · 2 comments
Closed
Labels
type: bug πŸ› Something isn't working

Comments

@hacheigriega
Copy link
Member

πŸ› Bug Report

I have noticed that the gas estimation is very off in the newly added pubkey module's add-seda-keys transaction. Check on the branch hy/pkr-refactor (or feat/pkr after the issue #320 is merged) by running:

❯ sedad tx pubkey add-seda-keys --from satoshi --keyring-backend test --fees 1000000000000aseda --gas auto --gas-adjustment 1.5
gas estimate: 88632
auth_info:
  fee:
    amount:
    - amount: "1000000000000"
      denom: aseda
    gas_limit: "88632"
    granter: ""
    payer: ""
  signer_infos: []
  tip: null
body:
  extension_options: []
  memo: ""
  messages:
  - '@type': /sedachain.pubkey.v1.MsgAddKey
    indexed_pub_keys:
    - index: 0
      pub_key:
        '@type': /cosmos.crypto.secp256k1.PubKey
        key: AiXs2yv75cYrmR5ptl25UVISL3a/3IQKVmEE6lJyJcwD
    validator_addr: sedavaloper1nsnv4g2ejq36asujaettw4ge73pzzpjf86208z
  non_critical_extension_options: []
  timeout_height: "0"
signatures: []
confirm transaction before signing and broadcasting [y/N]: y
code: 13
codespace: sdk
data: ""
events: []
gas_used: "0"
gas_wanted: "0"
height: "0"
info: ""
logs: []
raw_log: 'insufficient fees; got: 1000000000000aseda required: 886320000000000aseda:
  insufficient fee'
timestamp: ""
tx: null
txhash: 1A281730AFCB1B2E3F64AC4FB1314ABAA4010D37EF357C966790EC080D3E9438
@hacheigriega hacheigriega added the type: bug πŸ› Something isn't working label Aug 23, 2024
@hacheigriega hacheigriega mentioned this issue Aug 23, 2024
3 tasks
@Thomasvdam
Copy link
Member

To me the error reads that your fee is insufficient? The gas simulation runs and gives you 88632 and the node requires a minimum gas price of 10000000000 which is not covered by the fee of 1000000000000 you pass. Or am I missing something?

@hacheigriega
Copy link
Member Author

Sorry and thanks..πŸ™ πŸ₯² I confused gas prices flag with fees flag there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug πŸ› Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants