feat: Add SEDA Keys #320
Merged
feat: Add SEDA Keys #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasvdam
approved these changes
Aug 23, 2024
| @@ -206,20 +206,15 @@ func LoadVRFKey(keyFilePath string) (*VRFKey, error) { | |||
| // If loadPath is specified, it loads the VRF key file at the specified | |||
| // path. Otherwise, it generates a new VRF key, whose entropy is randomly | |||
| // generated or obtained from the mnemonic, if provided. | |||
| func LoadOrGenVRFKey(config *cfg.Config, loadPath, mnemonic string) (vrfPubKey sdkcrypto.PubKey, err error) { | |||
| func LoadOrGenVRFKey(config *cfg.Config, loadPath string) (vrfPubKey sdkcrypto.PubKey, err error) { | |||
There was a problem hiding this comment.
I'm not 100% sure how the dependency between the PKR and other modules is going to look. I thought the pubkeys was going to generate all required keys and the modules that utilise them 'just' send data to the module to have it signed with the correct key.
Comment on lines
+48
to
+50
| if err := m.Keeper.PubKeys.Set(ctx, collections.Join(valAddr, indPubKey.Index), pubKey); err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
For a different PR: move the knowledge of the store/collections out of the message server?
|
Thanks for the reviews.. I will address them after fixing the JSON unmarshalling issue I found while adding CLI tests. |
|
Done but there is a gas estimation issue to be addressed in a separate PR (See Issue #341) |
hacheigriega
force-pushed
the
hy/pkr-refactor
branch
from
64465c9
to
7931d46
Compare
hacheigriega
force-pushed
the
hy/pkr-refactor
branch
from
7931d46
to
7bb630d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Changes
This PR adds the last component of the pubkey module, the SEDA keys. This implements a CLI command for generating a set of SEDA keys and publishing their public keys on chain. Each of the SEDA keys are generated from a random seed, and they are stored in a single key file
seda_keys.jsonunder the same directory where the consensus private key is saved to. This means that, if any of the keys is lost, the user must re-generate and rotate all of his or her SEDA keys.To generate the SEDA keys and register their public keys on chain, run:
To query the validator's list of SEDA public keys:
When the SEDA Protocol requires a new key to be registered on chain, the
add-keycommand would be updated to generate the new key at some unused index.Related PRs and Issues
TODO
x/pkrtox/pubkeyCloses #162