feat: adding basic tally structure #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeshErBojhaa
reviewed
Jun 5, 2024
DeshErBojhaa
reviewed
Jun 5, 2024
gluax
reviewed
Jun 17, 2024
| } | ||
|
|
||
| // 4. Post result. | ||
| // msg := []byte("{\"data_requests\": {}}") |
There was a problem hiding this comment.
It's not relevant yet; just linking the appropriate rust for the json.
https://github.com/sedaprotocol/seda-common-rs/blob/main/src/msgs/data_requests/types.rs#L112
|
Should be ready to be merged now as tally works until VM execution, which fails with an error. The execution phase can be addressed in a new PR. |
DeshErBojhaa
approved these changes
Jun 21, 2024
Comment on lines
+98
to
+103
| keys := make([]string, len(req.Reveals)) | ||
| i := 0 | ||
| for k := range req.Reveals { | ||
| keys[i] = k | ||
| i++ | ||
| } |
There was a problem hiding this comment.
Suggested change
| keys := make([]string, len(req.Reveals)) | |
| i := 0 | |
| for k := range req.Reveals { | |
| keys[i] = k | |
| i++ | |
| } | |
| keys := make([]string, 0, len(req.Reveals)) | |
| for k := range req.Reveals { | |
| keys = append(keys, k) | |
| } |
This was referenced Jun 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Changes
This PR implements the basic tally structure in the endblocker of the wasm-storage module. The endblocker first fetches tally-ready data requests from the SEDA contract, whose address is registered during the instantiation process. Then, the tally wasm associated with each of the data requests is executed on tally VM. The major missing parts are:
The PR also includes:
Testing
Currently, the tally mechanism is tested using a mock function that mocks the SEDA contract's
requests_by_statusquery endpoint.Closes #127 and #53 and #281