Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix empty event bug from wasm-storage module #305

Closed
wants to merge 1 commit into from
Closed

fix: fix empty event bug from wasm-storage module #305

wants to merge 1 commit into from

Conversation

99adarsh
Copy link
Contributor

Explanation of Changes

  • Removed EventStoreDataRequestWasmWrapper and EventStoreOverlayWasmWrapper wrappers for emitting events
  • Directly using EventStoreDataRequestWasm and EventStoreOverlayWasm proto event messages fixes the issue

Closes: #303

@hacheigriega
Copy link
Member

Thanks for the PR!! So these wrappers were introduced in #135 to remove unnecessary double quotes. Ideally we would like to fix this without undoing #135.

@hacheigriega
Copy link
Member

We should also address TestMarshalJSON() in msg_server_test.go if we make changes in the event types.

@99adarsh 99adarsh closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacheigriega hacheigriega Awaiting requested review from hacheigriega

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Empty event from wasm_storage module
2 participants
@99adarsh @hacheigriega