Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding build tag for Rosetta #321

Merged
merged 3 commits into from
Aug 15, 2024
Merged

fix: Adding build tag for Rosetta #321

merged 3 commits into from
Aug 15, 2024

Conversation

hacheigriega
Copy link
Member

Motivation

Adding an optional build tag called rosetta to determine whether to add Rosetta support or not.
To build with this tag using make, run:

ENABLE_ROSETTA=true make build

Related: #298
Thank you @Thomasvdam for the solution!

@hacheigriega hacheigriega requested a review from a team August 13, 2024 19:14
Copy link
Member

@Thomasvdam Thomasvdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels a little clunky but I think this is the way to Go 👉 😎 👉

@Thomasvdam
Copy link
Member

Thomasvdam commented Aug 13, 2024

Actually we might want to add a note somewhere that rosetta and static can't go together 🤔 Maybe in the Makefile and have it error when both tags are present?

Or we add require the static tag to not be set for the Rosetta file, I think you can do boolean logic with tags.

@hacheigriega
Copy link
Member Author

hacheigriega commented Aug 14, 2024

Added an error message when both ENABLE_ROSETTA and LINK_STATICALLY are set to true.

$ LINK_STATICALLY=true ENABLE_ROSETTA=true make build                                                      
Makefile:78: *** Cannot link statically when Rosetta is enabled.  Stop.

@hacheigriega hacheigriega merged commit ed48912 into main Aug 15, 2024
16 of 17 checks passed
@hacheigriega hacheigriega deleted the hy/rosetta-fix branch August 15, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants