Add registration message handling #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluax
reviewed
Aug 16, 2024
hacheigriega
approved these changes
Aug 16, 2024
Also introduces an admin address to make updates to the proxy config easier for operators. An alternative would be to use a sequence number, but that makes the whole managamenet process more cumbersome for the operator. Part-of: #316
Thomasvdam
force-pushed
the
feat/data-proxy-registry
branch
from
26927e1
to
456c0dc
Compare
Thomasvdam
force-pushed
the
chore/data-proxy-registration
branch
from
7c4ef50
to
926a38d
Compare
Thomasvdam
force-pushed
the
chore/data-proxy-registration
branch
from
926a38d
to
2ddb4d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Also introduces an admin address to make updates to the proxy config easier for operators. An alternative would be to use a sequence number, but that makes the whole managamenet process more cumbersome for the operator.
Explanation of Changes
Testing
Added tests for the message server. If there are other tests that make sense at this stage I would love to learn!
Warning
The happy_path_with_memo test fails since we don't have a test vector where a message with memo was signed.
Related PRs and Issues
Part-of: #316