chore(data-proxy): update proxy query not found error #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluax
approved these changes
Aug 16, 2024
|
I approved, but I wasn't sure if the tests were supposed to fail on this one. |
hacheigriega
approved these changes
Aug 16, 2024
Thomasvdam
force-pushed
the
chore/data-proxy-registration
branch
2 times, most recently
from
926a38d
to
2ddb4d1
Compare
Thomasvdam
force-pushed
the
chore/data-proxy-query
branch
from
fab704e
to
4ed1bdf
Compare
Also conform to new import formatting rules. Part-of: #316
Thomasvdam
force-pushed
the
chore/data-proxy-query
branch
from
4ed1bdf
to
6d3372c
Compare
Base automatically changed from
chore/data-proxy-registration
to
feat/data-proxy-registry
August 17, 2024 12:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Give the user better feedback when a public key does not have an associated data proxy config registered.
Explanation of Changes
Not much, just updating what was already there from the boilerplate, adding tests, and making the error a little more user friendly when an unknown public key is queried.
Testing
Added tests for the query server.
Related PRs and Issues
Part-of: #316