style: 💄 simplify coloured banner using negative margin values #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a mistakenly committed line and not related to this PR
signekb
changed the title
|
I will merge this without reviews, so I can use these changes in an upcoming PR. |
signekb
added a commit
to seedcase-project/seedcase-website
that referenced
this pull request
Oct 10, 2024
## Description Based on the recent changes in the css theme (seedcase-project/seedcase-theme#56, seedcase-project/seedcase-theme#57, seedcase-project/seedcase-theme#58), I have updated the landing page styling. This includes: 1) delete `style.css` and link to `landing-page-theme.css` instead 2) use `full-width-banner` instead of old `landing-page-banner` ## Reviewer Focus <!-- Please delete as appropriate: --> This PR needs a quick review. Focus on CHANGES.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm in the proces of making the landing page for Sprout and I was (re-)annoyed with how complex the css for creating a coloured banner ended up, when I created the landing page for Seedcase.
So I looked into it again and found a simpler and (in my opinion) better solution 🥳
Note: I will create a PR using this in the
seedcase-websiterepo, since the landing page will be broken by removinglanding-page-bannerandlanding-page-banner-content.Reviewer Focus
This PR needs a quick review.
Focus on CHANGES.
Checklist