Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn and exit if boto version is too old #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jimbrowne
Copy link

Support for S3 encryption appeared in Boto 2.1.0; support for S3 reduced redundancy appeared in Boto 2.0. Sadly many Linux distributions still contain a pre-2.0 boto. It's better to proactively check that the available boto library is recent enough for boto-rsync to function.

@seedifferently
Copy link
Owner

@jimbrowne Thanks for the pull req. However, I'm not really sure why this is necessary seeing as the setup script requires boto 2.1.1 (https://github.com/seedifferently/boto_rsync/blob/master/setup.py#L7) and any of the "approved" methods for installing boto-rsync should go through that.

Are you expecting people to be installing/implementing this script in more unconventional ways?

@jimbrowne
Copy link
Author

I noticed that this morning when re-packaging. Honestly I can't remember how I wound up with the script on the machine with an old boto version; could have been from just performing a git clone of the repo. I have a number of boto-related scripts that people tend to use directly from a git repo (c.f. https://github.com/jimbrowne/awstools) so it's a pattern I have baked into my reflexes. If your opinion is that only the "approved" installation methods should be supported I don't disagree with that.

@seedifferently
Copy link
Owner

Thanks, I will think on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants