Improve card model tests

test/Bitreserve/Tests/Unit/Model/CardTest.php

@@ -14,7 +14,7 @@ class CardTest extends TestCase
      */
     public function shouldReturnInstanceOfCard()
     {
-        $data = array('id' => '1');
+        $data = array('id' => $this->faker->randomDigitNotNull);
 
         $client = $this->getBitreserveClientMock();
 
@@ -24,12 +24,24 @@ public function shouldReturnInstanceOfCard()
         $this->assertInstanceOf('Bitreserve\Model\Card', $card);
     }
 
+    /**
+     * @test
+     *
+     * @expectedException PHPUnit_Framework_Error
+     * @expectedExceptionMessage Argument 1 passed to Bitreserve\Model\Card::__construct() must be an
+     *                           instance of Bitreserve\BitreserveClient, string given
+     */
+    public function shouldThrowExceptionWhenFirstArgumentIsNotAnInstanceOfBitreserveClient()
+    {
+        $card = new Card('foo', 'bar');
+    }
+
     /**
      * @test
      */
     public function shouldReturnId()
     {
-        $data = array('id' => '1');
+        $data = array('id' => $this->faker->randomDigitNotNull);
 
         $client = $this->getBitreserveClientMock();
 
@@ -57,7 +69,7 @@ public function shouldReturnAddress()
      */
     public function shouldReturnLabel()
     {
-        $data = array('label' => 'My Card');
+        $data = array('label' => $this->faker->sentence(3));
 
         $client = $this->getBitreserveClientMock();
 
@@ -71,7 +83,7 @@ public function shouldReturnLabel()
      */
     public function shouldReturnCurrency()
     {
-        $data = array('currency' => 'BTC');
+        $data = array('currency' => $this->faker->currencyCode);
 
         $client = $this->getBitreserveClientMock();
 
@@ -85,7 +97,7 @@ public function shouldReturnCurrency()
      */
     public function shouldReturnBalance()
     {
-        $data = array('balance' => '12.34');
+        $data = array('balance' => $this->faker->randomFloat);
 
         $client = $this->getBitreserveClientMock();
 
@@ -99,7 +111,7 @@ public function shouldReturnBalance()
      */
     public function shouldReturnAvailable()
     {
-        $data = array('available' => '12.34');
+        $data = array('available' => $this->faker->randomFloat);
 
         $client = $this->getBitreserveClientMock();
 
@@ -127,7 +139,7 @@ public function shouldReturnLastTransactionAt()
      */
     public function shouldReturnSettings()
     {
-        $data = array('settings' => array('position' => '3', 'starred' => true));
+        $data = array('settings' => array('position' => $this->faker->randomDigitNotNull, 'starred' => true));
 
         $client = $this->getBitreserveClientMock();
 
@@ -196,10 +208,10 @@ public function shouldCreateNewTransaction()
         $cardData = array('id' => 'ade869d8-7913-4f67-bb4d-72719f0a2be0');
 
         $postData = array(
-            'destination' => 'luke.skywalker@rebelalliance.org',
+            'destination' => $this->faker->email,
             'denomination' => array(
-                'amount' => '0.1',
-                'currency' => 'BTC',
+                'amount' => $this->faker->randomFloat,
+                'currency' => $this->faker->currencyCode,
         ));
 
         $data = array(

test/Bitreserve/Tests/Unit/Model/TestCase.php

@@ -2,10 +2,12 @@
 
 namespace Bitreserve\Tests\Unit\Model;
 
+use Bitreserve\Tests\Unit\TestCase as BaseTestCase;
+
 /**
  * TestCase.
  */
-abstract class TestCase extends \PHPUnit_Framework_TestCase
+abstract class TestCase extends BaseTestCase
 {
     /**
      * Get Model class.