apac, seekBusiness: Use strong
weight instead of medium
for Thai characters
#1331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unicode range of Thai characters is not satisfied by the preferred fonts specified for the
apac
theme, resulting in these characters falling through and being rendered bysans-serif
— which applies a platform specific font.On Mac this is
Thonburi
, on Windows it isTahoma
, neither of which have support for the semi-bold weight chosen formedium
. The result is the visual weight ofmedium
text being rounded down toregular
, and hence having no differentiation against standard text in the UI.To work around this, we are creating a font alias that coerces the semi-bold weight to the bold weight of the previously mentioned platform specific Thai fonts. This is only applied for themes that inherit the
apac
typography definition (currentlyapac
andseekBusiness
), and will only affect characters that fall through — unsatisfied by the preferred fonts in the specifiedfont-family
.Screenshots
Before / After
Playroom Previews
Before / After
Note
Also reintroducing the
js-yaml
dependency which was removed previously, as it required by the snapshot publishing process.