Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apac, seekBusiness: Use strong weight instead of medium for Thai characters #1331

Merged
merged 7 commits into from
Aug 4, 2023

Conversation

michaeltaranto
Copy link
Contributor

The unicode range of Thai characters is not satisfied by the preferred fonts specified for the apac theme, resulting in these characters falling through and being rendered by sans-serif — which applies a platform specific font.

On Mac this is Thonburi, on Windows it is Tahoma, neither of which have support for the semi-bold weight chosen for medium. The result is the visual weight of medium text being rounded down to regular, and hence having no differentiation against standard text in the UI.

To work around this, we are creating a font alias that coerces the semi-bold weight to the bold weight of the previously mentioned platform specific Thai fonts. This is only applied for themes that inherit the apac typography definition (currently apac and seekBusiness), and will only affect characters that fall through — unsatisfied by the preferred fonts in the specified font-family.

Screenshots

Before / After
Before and after

Playroom Previews

Before / After

Note

Also reintroducing the js-yaml dependency which was removed previously, as it required by the snapshot publishing process.

@michaeltaranto michaeltaranto requested a review from a team as a code owner August 2, 2023 05:31
@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

🦋 Changeset detected

Latest commit: 2a67c7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

.changeset/afraid-birds-move.md Outdated Show resolved Hide resolved
.changeset/afraid-birds-move.md Outdated Show resolved Hide resolved
.changeset/afraid-birds-move.md Outdated Show resolved Hide resolved
Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
@michaeltaranto michaeltaranto merged commit 12d8d72 into master Aug 4, 2023
@michaeltaranto michaeltaranto deleted the apply-thai-weight-fix branch August 4, 2023 00:12
@seek-oss-ci seek-oss-ci mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants