Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer: Prevent close button protruding in left position #1351

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

michaeltaranto
Copy link
Contributor

Fixes an issue where the close button could protrude from a Drawer.
This was only visible when setting position to left and between a small range of screen widths — above 660px (small content width) and below 768px (tablet breakpoint).

image

@michaeltaranto michaeltaranto requested a review from a team as a code owner August 28, 2023 01:06
@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2023

🦋 Changeset detected

Latest commit: fd3db71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@michaeltaranto michaeltaranto merged commit 504ea20 into master Aug 28, 2023
5 checks passed
@michaeltaranto michaeltaranto deleted the drawer-close-overflow branch August 28, 2023 04:32
@seek-oss-ci seek-oss-ci mentioned this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants