Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Capsize built with Crackle #1449

Merged
merged 8 commits into from
Feb 19, 2024
Merged

Use Capsize built with Crackle #1449

merged 8 commits into from
Feb 19, 2024

Conversation

mrm007
Copy link
Contributor

@mrm007 mrm007 commented Feb 12, 2024

Had to change to moduleResolution: bundler so Capsize exports are seen correctly by TypeScript.
Due to the above change, I had to bump didyoumean2 to latest so types are resolved correctly. There are no breaking changes other than dropping support for Node.js < 18.12.

Note: this is using a snapshot version of Capsize. It will need to be updated after seek-oss/capsize#168 is merged and released.

Copy link

changeset-bot bot commented Feb 12, 2024

⚠️ No Changeset found

Latest commit: 3d1510d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrm007 mrm007 marked this pull request as ready for review February 12, 2024 02:11
@mrm007 mrm007 requested a review from a team as a code owner February 12, 2024 02:11
@michaeltaranto michaeltaranto merged commit 9400393 into master Feb 19, 2024
8 checks passed
@michaeltaranto michaeltaranto deleted the crackled-capsize branch February 19, 2024 02:21
michaeltaranto added a commit that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants