Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

braid-design-system: Update some runtime dependencies, move some types deps to dev deps #1502

Merged
merged 1 commit into from
May 30, 2024

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented May 29, 2024

  • Bump some deps that are behind by major versions (dedent brings its own types now, hence the removal of @types/dedent).
  • Moved @types deps to dev deps (I checked, they're not part of Braid's public API)
  • Deduped lockfile This ended up bumping the react version, leading to test errors (key being spread into JSX). Rolled this change back.

@askoufis askoufis requested a review from a team as a code owner May 29, 2024 03:47
Copy link

changeset-bot bot commented May 29, 2024

🦋 Changeset detected

Latest commit: 1a87866

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
braid-design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@askoufis askoufis changed the title Update some runtime dependencies, move some types deps to dev deps, dedupe lockfile braid-design-system: Update some runtime dependencies, move some types deps to dev deps, dedupe lockfile May 29, 2024
@askoufis askoufis changed the title braid-design-system: Update some runtime dependencies, move some types deps to dev deps, dedupe lockfile braid-design-system: Update some runtime dependencies, move some types deps to dev deps, dedupe lockfile May 29, 2024
@askoufis askoufis changed the title braid-design-system: Update some runtime dependencies, move some types deps to dev deps, dedupe lockfile braid-design-system: Update some runtime dependencies, move some types deps to dev deps May 29, 2024
@askoufis askoufis merged commit 86056f0 into master May 30, 2024
6 checks passed
@askoufis askoufis deleted the update-runtime-deps branch May 30, 2024 00:23
@seek-oss-ci seek-oss-ci mentioned this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants