fix: Make 'react' a peer dependency, use yarn lock file #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.npmrc
Outdated
| @@ -1 +0,0 @@ | |||
| package-lock=false | |||
There was a problem hiding this comment.
Since we're using Yarn, wouldn't we need to keep this setting to disable npm's package locking?
There was a problem hiding this comment.
I was under the incorrect impression that yarn honoured this setting.
Have tested and confirmed it doesn't. I'll add this back in. Thanks
package.json
Outdated
| }, | ||
| "peerDependencies": { | ||
| "react": "^16.0.0", | ||
| "react-dom": "^16.0.0" |
There was a problem hiding this comment.
I don't think react-dom is a peer dependency. We only import react in our package code.
markdalgleish
changed the title
markdalgleish
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peer dependencies
reacthas been shifted to peer dependencies. This allows consuming apps to define their own React dependency, ensuring that duplicate versions of React are not used.Lock file
We've added a
yarn.lockfile that ensures that installs usingyarnget exactly the same dependencies regardless of when they are installed.