Set minimumReleaseAge to 0 for @seek/ #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samchungy
commented
Oct 14, 2024
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "$schema": "https://docs.renovatebot.com/renovate-schema.json", | |||
There was a problem hiding this comment.
Gives us nicer DX
AaronMoat
approved these changes
Oct 14, 2024
72636c
reviewed
Oct 14, 2024
Comment on lines
+239
to
+246
| { | ||
| "matchManagers": ["npm"], | ||
| "matchDepNames": ["^@seek/*"], | ||
| "matchUpdateTypes": ["major", "minor", "patch"], | ||
| "schedule": "before 3:00 am every weekday", | ||
| "minimumReleaseAge": "0 days", | ||
| "updateNotScheduled": true | ||
| }, |
There was a problem hiding this comment.
Is this meant to be the same as
Lines 150 to 158 in 8f6d1b4
It's possible there's an issue with specifying both matchDepNames and matchPackagePatterns, and we should probably migrate all of the latter to the former across the configuration.
There was a problem hiding this comment.
Possibly, I'll give it a test in my renovate repo
There was a problem hiding this comment.
Ooo I think we want packageName so matchPackageName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The $schema is a little off but I'm fixing that: renovatebot/renovate#31938