Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert range strategy to "replace" #83

Merged
merged 2 commits into from
Mar 19, 2023
Merged

Revert range strategy to "replace" #83

merged 2 commits into from
Mar 19, 2023

Conversation

72636c
Copy link
Member

@72636c 72636c commented Mar 17, 2023

Per renovatebot/renovate#19800, the "auto" strategy now raises additional PRs to update dependencies in range. This is either unsuitable for our use case or bugged, as we have "lockfile update" PRs (as denoted by a -lockfile branch suffix) which are bumping the in-range version of a package's production dependencies. This means that e.g. ^2.0.0 gets bumped to ^2.1.0 and so on, and results in a lot of transitive noise for projects that consume the package.

I've also patched in widening of peer dependency ranges which is what "auto" was previously described as doing.

https://docs.renovatebot.com/configuration-options/#rangestrategy

https://docs.renovatebot.com/release-notes-for-major-versions/#version-35

renovatebot/renovate#20990

Per renovatebot/renovate#19800, the "auto" strategy now raises
additional PRs to update dependencies in range. This is either
unsuitable for our use case or bugged, as we have "lockfile update" PRs
(as denoted by a `-lockfile` branch suffix) which are bumping the
in-range version of a package's production dependencies. This means that
e.g. `^2.0.0` gets bumped to `^2.1.0` and so on, and results in a lot of
transitive noise for projects that consume the package.

This _may_ break the previous behaviour of widening peer dependency
ranges, but's a lesser concern now and I'm following up on the Renovate
recommendation for handling this use case.

https://docs.renovatebot.com/release-notes-for-major-versions/#version-35

renovatebot/renovate#20990
@72636c 72636c requested a review from a team as a code owner March 17, 2023 22:34
72636c added a commit to seek-oss/skuba that referenced this pull request Mar 19, 2023
72636c added a commit to seek-oss/skuba that referenced this pull request Mar 19, 2023
@72636c 72636c merged commit 630a808 into master Mar 19, 2023
@72636c 72636c deleted the range-strategy-replace branch March 19, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants