Replace @antfu/ni and remove @manypkg/find-root
#1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1098eb8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
felixhabib
approved these changes
Aug 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@antfu/niis both a CLI and a library, but we don't use the CLI in sku.package-manager-detector(also an antfu package) is basically just the package manager detection/command constructor part of@antfu/ni, which is all we need.I've also removed
@manypkg/find-root, which IMO has a bad API anyway, with just usingfind-up(an existing sku dep) to find the closest lockfile. This is pretty much the same method@manypkg/find-rootandpackage-manager-detectoruse internally anyway.The reason we don't use
package-manager-detectorto detect the package manager is because it only provides an async function to do so, which we can't use in ourpackageManagermodule as it relies on the global scope.