Snapshots #1295
Open
Snapshots #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Paused until the new year, need to look more closely at how metadata is updated and passed |
|
Merged main to branch, updated tests and resolved conflicts. |
|
Is this for 1.14 or 1.15? |
1.15 |
fbacall
reviewed
Aug 23, 2023
| @@ -43,6 +43,7 @@ def export_to_zenodo(access_token, extra_metadata = {}) | |||
| metadata.merge!(extra_metadata.to_h.deep_symbolize_keys) | |||
|
|
|||
| #FIXME: this is a quick hack | |||
| metadata[:title] = 'not set' if metadata[:title].blank? | |||
There was a problem hiding this comment.
The Zenodo export needs thinking about, because the snapshot title/description may not be what you want to be the title/description of the Zenodo entry (currently it would be the title/description of the resource being snapshotted).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom title and description to snapshots, and the option to edit them as long as they don't have a DOI assigned.