Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fixtures by factories #1665

Merged
merged 19 commits into from
Nov 20, 2023
Merged

Replace fixtures by factories #1665

merged 19 commits into from
Nov 20, 2023

Conversation

kdp-cloud
Copy link
Collaborator

@kdp-cloud kdp-cloud commented Nov 17, 2023 •
edited
Loading

In this PR:

  • All ISA Tag and templates fixtures are replaced by Factories.
  • Extra little bug fix for dynamic table

@kdp-cloud kdp-cloud added this to the v1.15.0 milestone Nov 17, 2023
@kdp-cloud kdp-cloud self-assigned this Nov 17, 2023
@kdp-cloud kdp-cloud linked an issue Nov 17, 2023 that may be closed by this pull request
Replace ISA Tag fixtures by factories #1664
Closed
@kdp-cloud kdp-cloud marked this pull request as ready for review November 17, 2023 16:00
@kdp-cloud kdp-cloud merged commit df3195f into seek4science:main Nov 20, 2023
11 checks passed
@kdp-cloud kdp-cloud deleted the replace_fixtures_by_factories branch November 20, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuzart stuzart stuzart approved these changes

Assignees

@kdp-cloud kdp-cloud

Labels
None yet
Projects
SEEK 1.15.x
Status: Done
Milestone
v1.15.0
Development

Successfully merging this pull request may close these issues.

Replace ISA Tag fixtures by factories
2 participants
@kdp-cloud @stuzart