MailDeliveryJob to updates with settings and avoids needing to restart. #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbacall
reviewed
Nov 28, 2024
| @@ -55,6 +55,7 @@ | |||
| <%= link_to '#', id: 'queue-test-email-btn', class: 'btn btn-default' do %> | |||
| <%= image("test", title: "Send testing email", alt: "Test")%> Queue test email | |||
| <% end %> | |||
| <p class="help-block">Note that testing the Queue requires settings to be saved first</p> | |||
There was a problem hiding this comment.
Perhaps in the future we could make the custom job take an optional hash of SMTP settings to temporarily override the saved settings, so it can be used for testing without needing to save the settings first.
fbacall
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of MailDeliveryJob to update smtp settings before running.
Also always start the mailer job, but only send mails if enabled, to avoid having to restart the jobs if enabling email. ( I'm in 2 minds about this and open to reverting it after review. )
Added a note that when queuing a test email, the settings need to have been saved first.