-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G14 2024 Slash lighting stays on when lid is closed & plugged in #2381
Comments
@c3-ziqin hello, Well, it sends a command to matrix to turn it completely off on actual Lid Close event (i.e. same as you would select OFF in dropdown)
|
@seerge thanks for the quick reply! If you mean turning the slash off, yes it's off all the time. And when lid is closed the light pattern is different from the settings, a slow breathing pattern. I have my Armoury uninstalled, let me reinstall and try once. |
@c3-ziqin ok, it's a lot of checkboxes in AC. I don't know payloads for them ... Try this build and let me know if it makes any difference (but change "lid close" checkbox status there manually first) Alternatively I will need you to record actual data that AC sends to the device when you check / uncheck those settings. |
@c3-ziqin any update on the matter? |
Hello @seerge I also have this issue with the 2024 G14; I tried installing the build you shared with @c3-ziqin but I still see the slash lighting when the lid's closed and the device is plugged-in. |
@Eisenhorn76 can you post a log from that build ? |
@seerge I'd like to help but I'm not familiar with how to do that. |
@Eisenhorn76 it's under |
@seerge sure, here's what I got 4/7/2024 7:15:51 PM: Matrix LidClosed: True |
@Eisenhorn76 i don't see a command that was added in a build here. Did you use correct build? Did you check / uncheck "disable on lid close" checkbox and tested afterwards? can you upload full log by just drag-n-dropping it here? |
@Eisenhorn76 thanks. If it still doesn't work the only way to actually check what AC sends in order to disable it - is to record that. I have explained process in high details in this thread (it requires AC and extra app installed). If you want you can record commands for |
Thanks @seerge I actually uninstalled AC after I saw how much more efficient gHelper was so I'll need to re-install. Will have a read through that thread you shared and get back to you. |
@Constrat no, it's separate. Slash Lightning apparently has a separate command to let it stay on / off when lid is closed . For lightbar - it's brightness is tied to general keyboard brightness, right ? If so app sets brightness to 0 when you close lid (but keep laptop awake). You can see it in a log. |
Yeah turning off they keyboard makes it also turn off the lightbar even with the screen turned. I'm guessing there are no "additional" options to do that automatically, in the sense of keep everything turned off even when plugged in if lid is closed. |
@c3-ziqin @Eisenhorn76 @adelbtw can you check if this build makes any difference ? |
As soon as I am home and have access to my charger I will check it out and let you know. |
@seerge Yes! It worked perfectly! Thank you so much. |
@adelbtw great news. Is it for both situations when laptop is plugged and on battery ? |
@seerge It was never an issue for me where the the lights would be on when on battery. |
@seerge So after re-applying my power limits, it seems like the Disable Lid on Close just deosnt work anymore. Im back at the lid lighting up when the lid closes. Here is the log file in case you need it I guess? EDIT: After deleting all my settings and basically starting from stcratch, I noticed that the lid only starts glowing on close after I changed the power limits on the "Turbo"setting. I, by no means, know what I am looking at whatsoever, but it seems to me like there is maybe an issue related to the way the power limits work?? Here is the log file after a "clean install"of GHelper. |
@adelbtw so, it doesn't work, right ? Then I need someone with actual device to actually record payloads from Armoury checkboxes as explained above. |
@seerge After restarting my laptop… it seems to work now? Im getting mixed signals. It seems to work half of the time. I can try to get you the Armoury Crate payloads, however my schedule is packed tomorrow. I could get them by around Midday Saturday if thats alright? |
@adelbtw that's fine. There is 2 separate settings in AC
Currently app sets only Lid Closed setting. |
@seerge hopefully this helps I toggled each of these on and off. |
@AlecMulder @adelbtw @Eisenhorn76 Ok, great.
I have updated checkbox in the app, so it will set slash setting to OFF when chackled for both sleep / lid close states P.S. Please make sure to either check or uncheck it at least once, cause it sets flags only when clicked :) |
@seerge disable on lid closed ON, lid close = slash off, put to sleep = slash stays on to set animation |
@AlecMulder ok, So if "Sleep Animation" option is selected (in AC) it runs a "special" animation and if not - it runs whatever was running during awake state ? How did it work with AC and you were setting settings ? Did Sleep animation remain running if lid was closed ? Try this build. When "disable on lid close" is checked it will do same as before - set sleep animation to OFF and set active on lid close to OFF, but also next to that it will set main mode to off as well |
@seerge I'm having trouble with the "stay activate animation pattern when lid is closed" setting in AC. It doesn't seem to be doing anything for some reason. You're correct on the sleep setting in AC, it's a full slash breathing animation as mentioned in the top post. for me right now, lid closed isn't changing anything unless I use ghelper. I can activate the sleep animation using sleep under the windows power menu, otherwise it runs the selected animation at all times. I'm not sure what you mean by main mode off in the latest build, but I don't notice a difference. Same behavior as my previous post. |
@AlecMulder so latest build i linked is still not able to turn off lighting when lid is closed ? Under main mode - i mean that next to sending commands from AC checkboxes g-helper would also set lighting brightness to OFF. |
@AlecMulder any updates ? :) |
@seerge If that's all you're looking for, yes the disable on lid close checkbox works, but if that's all you were worried about why is the sleep animation involved? Maybe we should start over a bit and tell me what to test, there are a few issues reported above but I'm unable to recreate them. As mentioned before, this is the behavior I'm seeing with your latest build. If I tell the computer to sleep without closing the lid, the slash stays on in one way or another. But maybe we're not worried about that / can't do anything about it. If that's the case, shouldn't the sleep setting be a separate checkbox? |
@AlecMulder what people above complained is that they were not able to force Slash Lighting to turn completely off when lid is closed. And since app was already setting Slash brightness to OFF and setting Lid Close flag, my assumption was that what people actually see is sleep animation :) And that's the only change I did so far (based on your recordings, thanks).
This is exactly how latest build works. The only downside that I see is that it kind of forces sleep animation to be ON when |
@AlecMulder as an alternative I can offer other thing - bundling "sleep animation" status with brightness dropdown. So if it's OFF - Sleep Animation is also OFF, when it's Dim and above -> Sleep Animation is ON |
@AlecMulder can you check please : if you set Slash brightness to 0 (in AC) or to OFF in G-Helper but turn Sleep Animation ON - does it actually start running it ? |
@seerge Thank you for the detailed replies. Yea, I'm not sure how to test the sleep states. My power settings are set to go to sleep on lid close.. so would that show the sleep animation prior to this build? When? I just tested your last request, sleep animation is displayed even if slash is set to off within ghelper and disable on lid close OFF. Same within AC. If sleep animation is on, sleep animation activates during sleep state regardless of slash state. |
I hope I'm not speaking out of turn. But I installed the latest update. For me (GA403 UV) I can confirm that closing the lid turns off the slash lighting if 'disable on lid close' is checked. However, slash lighting remains on if I choose sleep from the start menu. Thank you for that! However, If I have Slash Lighting enabled, if I close the lid, it does not engage the sleep pattern. Instead, slash lighting remains on at the current selected pattern. It would be nice to have the option to choose 'sleep pattern on lid close' or something similar. Thanks agian for a wonderful utility Serge! |
@batsai @AlecMulder try this build, It should bundle "sleep" animation with slash lighting brightness status. I.e. if slash is OFF - sleep is also set to OFF and vice-versa. This behavior is same as anime-matrix behaves on old devices btw (except there it's just hardcoded) |
@seerge Update confirmed working. If slash set to OFF in ghelper, sleep animation doesn't activate when put to sleep from power menu. Slash stays off as expected. |
@AlecMulder great. Does |
@seerge it seems no matter the checkbox state, closing the lid turns the slash off. During both battery and plugged in. For some reason I'm also seeing this on previous builds so I'm not sure what changed, but it's not consistent with my results over the past few days. |
@AlecMulder hm. Can you change this somehow in AC (instead of G-Helper) ? |
@seerge Wow! That was fast! On build 167, when plugged in, 'disable on lid close' works perfectly. When 'disable on lid close' is unchecked, the current animation continues when I close the lid. If however, the laptop goes to sleep with the slash lighting on and the lid open, the sleep animation turns on. Thanks so much! This software is incredible. Donated. 😊 |
@batsai great, can you check if correct behavior remains in last build posted in this thread as well ? (bundling sleep animation with slash brightness) |
Rules
What's wrong?
Slash lighting on the 2024 G14 model stays on (breathing pattern) when lid is closed + plugged in. This happens when "Disable on lib close" is selected. But when not plugged in slash lighting goes off when lid is closed.
Windows dynamic lighting is turned off.
My setting is below:
How to reproduce the bug?
Logs
log.txt
Log when laptop is plugged in
When laptop is not plugged in:
Device and Model
Zephyrus G14 GA403UI
Additional information.
Looking at the log, it seems that when lid is closed the log is same when plugged in and not plugged in.
Armoury Crate
Uninstalled
Asus Services
None
Version
0.164.0
OS
Windows 11 23H2
The text was updated successfully, but these errors were encountered: