Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zephyrus G16 2024 Incorrect Slash Lighting Preset on Lid Close #2815

Closed
2 tasks done
sgDanPowell opened this issue Jul 7, 2024 · 17 comments
Closed
2 tasks done

Zephyrus G16 2024 Incorrect Slash Lighting Preset on Lid Close #2815

sgDanPowell opened this issue Jul 7, 2024 · 17 comments
Labels
answered question Further information is requested

Comments

@sgDanPowell
Copy link

Rules

  • I made myself familiar with the Readme, FAQ and Troubleshooting.
  • I understand that, if insufficient information or no app logs will be provided, my issue will be closed without an answer.

What's wrong?

Disabling Slash lighting when Lid is closed works correctly; however, if you keep the Slash lighting enabled when the lid is closed it appears to use the settings you previously had in Armory Crate rather than the setting you have in G Helper.

How to reproduce the bug?

Keep Slash Lighting Enabled in G Helper.
Close the Laptop Lid.
Observe that the Lighting preset may be different to the one you have selected in G Helper due to it defaulting to the setting selected for closed lid in Armory crate.

Logs

log.txt

Device and Model

GU605MZ-QR045W

Additional information.

No response

Armoury Crate

Uninstalled

Asus Services

0

Version

0.178.0

OS

Windows 11 Home 22H2

@seerge
Copy link
Owner

seerge commented Jul 7, 2024

@sgDanPowell hello, it's not AC animation. It's most likely sleep animation that you see when lid is closed :)

It's controlled by firmware, so you can't change that - only turn it off completely.

@seerge seerge added the answered label Jul 7, 2024
@sgDanPowell
Copy link
Author

The sleep animation can be controlled in Armory Crate IIRC?

@sgDanPowell
Copy link
Author

image

If I have "Stay activate animation pattern when lid is closed" then it seems to also play the Flux pattern I have selected when lid closed/sleep

This setting carries over even if you uninstall Armory Crate and use only G Helper - if I change to "Static" or another setting in G Helper, it keeps the above setting from armory crate

@seerge
Copy link
Owner

seerge commented Jul 8, 2024

@sgDanPowell

  • Are you sure that it plays animation previously selected, and not just some standard "lid close animation" (same for any mode)?
  • What happens if you would uncheck Stay activate animation pattern when lid is closed in AC and close the lid ?

@seerge seerge added the question Further information is requested label Jul 8, 2024
@sgDanPowell
Copy link
Author

Armory Crate settings examples:

Theme is Glitch. Animation Pattern is Bounce. Show Sleep Animation Pattern is TRUE. Stay Activate Animation Pattern when Lid is Closed is set to TRUE.

image

Theme is Glitch. Animation Pattern is Bounce. Show Sleep Animation Pattern is TRUE. Stay Activate Animation Pattern when Lid is Closed is set to FALSE.

image

Theme is Neoretro. Animation Pattern is Flux. Show Sleep Animation Pattern is TRUE. Stay Activate Animation Pattern when Lid is Closed is set to TRUE.

image

Theme is Neoretro. Animation Pattern is Flux. Show Sleep Animation Pattern is TRUE. Stay Activate Animation Pattern when Lid is Closed is set to FALSE.

image

@seerge
Copy link
Owner

seerge commented Jul 8, 2024

@sgDanPowell great, thanks for the info. But what is the actual behavior of the SlashLighting when lid is closed in those situations ? Does setting "Stay Activate Animation Pattern" to FALSE - keep same animation as when lid is open ?

@sgDanPowell
Copy link
Author

Just uploading some comparison videos with the above settings now :)

@sgDanPowell
Copy link
Author

But yes, it appears that when Stay Activate Animation Pattern is flagged as True, it keeps the same pattern. When it is flagged as false, it appears to revert to a generic pulsing pattern as videos show

https://www.transfernow.net/dl/20240708WIQ2n5aT

@seerge
Copy link
Owner

seerge commented Jul 8, 2024

@sgDanPowell ok, blinking pattern is very similar to a default "sleep" animation on any asus keyboard (they also blink).

I know a payload for Stay Activate Animation Pattern checkbox. And I can simply turn it OFF all the time . Then it will keep default pattern when lid is closed.

I'm just not 100% sure if it's desired behavior for everyone and I also don't want to overcomplicate UI (even more) with an extra checkbox ....

What do you think ?

@seerge
Copy link
Owner

seerge commented Jul 8, 2024

@sgDanPowell try this build, it should keep default pattern ON all the time

GHelper.zip

@sgDanPowell
Copy link
Author

It does for the most part keep the Selected pattern on Lid closed, but it seems to revert back to the default static blinking pattern occasionally

@sgDanPowell
Copy link
Author

20240708_234128.mp4
20240708_234222.mp4

@Minemetero
Copy link

How do you keep your laptop clean? I left my finger oil on the slash lighting.

@seerge
Copy link
Owner

seerge commented Jul 9, 2024

@sgDanPowell ok great.

It's AC service that reverts it back probably :) You will need to disable it in windows services or (eventually) uninstall AC using uninstaller

@sgDanPowell
Copy link
Author

Appears to still revert after a short period of time once the machine is Sleeping with the Lid closed

Armory Crate was uninstalled using the official Armory crate uninstaller tool; unsure what service may be hijacking it back?

20240710_080137.mp4

@seerge
Copy link
Owner

seerge commented Jul 10, 2024

@sgDanPowell it could be another animation this time - "sleeping" (when laptop goes to sleep and it starts blinking)

I'm not sure if it's a good idea of disabling this one tho, as when you see it - you know that proper hardware sleep is ON now. So as for this part I would keep it as is now.

--

To summarize there are 2 "automated" animations for Slash Lighting

  • Lid close animation (this one is turned off now all the time)
  • Sleep animation (this one is untouched)

@seerge
Copy link
Owner

seerge commented Jul 12, 2024

@sgDanPowell changes pushed to the last 0.180 release.

I strongly suggest to keep sleep animation as is (cause then you can separate if device is sleeping or just has lid closed). And this is also same as Anime Matrix behaves in older devices. So it's consistent :)

Closing as resolved then.

@seerge seerge closed this as completed Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants