Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Lighting label on Windows 10 #2966

Closed
2 tasks done
karabaja4 opened this issue Aug 12, 2024 · 3 comments
Closed
2 tasks done

Dynamic Lighting label on Windows 10 #2966

karabaja4 opened this issue Aug 12, 2024 · 3 comments

Comments

@karabaja4
Copy link

karabaja4 commented Aug 12, 2024

Rules

  • I made myself familiar with the Readme, FAQ and Troubleshooting.
  • I understand that, if insufficient information or no app logs will be provided, my issue will be closed without an answer.

What's wrong?

There is a label saying "Please disable Windows > Dynamic Lighting" which opens Windows Settings on Windows 10.

image

However, I don't think there is an option to control Dynamic Lighting on Windows 10 - I think it this is a feature introduced in Windows 11.

Also, I see that the app is reading this registry key:

HKEY_CURRENT_USER\SOFTWARE\Microsoft\Lighting\AmbientLightingEnabled

Setting this key doesn't do anything on Windows 10 - the path does not exist unless created manually - which removes the label if set to 0, but still :)

If Dynamic Lighting is not supported, maybe it's a good idea to hide this label on Windows 10 so not to confuse the users?

How to reproduce the bug?

  1. Open G-Helper on Windows 10.
  2. Observe the label "Please disable Windows > Dynamic Lighting"

Logs

Device and Model

ASUS ROG Strix SCAR 18 G834YJR

Additional information.

No response

Armoury Crate

Uninstalled

Asus Services

No response

Version

0.181.0

OS

Windows 10 21H2

@seerge
Copy link
Owner

seerge commented Aug 12, 2024

@karabaja4 hello, can you check if this build works correctly ?

GHelper.zip

I have added a check based on https://stackoverflow.com/questions/69038560/detect-windows-11-with-net-framework-or-windows-api

@karabaja4
Copy link
Author

@seerge The build you provided works, the label is not displayed even without the registry key.

@seerge
Copy link
Owner

seerge commented Aug 12, 2024

@karabaja4 great!

@seerge seerge closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants