Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change keyboard lightning #2973

Closed
2 tasks done
Rooie100 opened this issue Aug 13, 2024 · 86 comments
Closed
2 tasks done

Can't change keyboard lightning #2973

Rooie100 opened this issue Aug 13, 2024 · 86 comments
Labels
question Further information is requested

Comments

@Rooie100
Copy link

Rules

  • I made myself familiar with the Readme, FAQ and Troubleshooting.
  • I understand that, if insufficient information or no app logs will be provided, my issue will be closed without an answer.

What's wrong?

As the title says, i cant change the lightning in G-helper. Only when i click ''run Asus services'' then it works. Dynamic lightning is disabled via windows.

I'm also using the latest version of G-helper.

How to reproduce the bug?

Go to G-helper
Click on a different color
Keyboard stays in breathing

Logs

log.txt

Device and Model

ASUS Vivobook S 15 OLED M5506NA.

Additional information.

No response

Armoury Crate

Uninstalled

Asus Services

None

Version

0.184.0

OS

Windows 11 H

@seerge
Copy link
Owner

seerge commented Aug 13, 2024

@Rooie100 hello,

Is it only backlight modes that don't work or also backlight brightness ?

Cause I see that brightness controls seem to exist on your device and work

8/13/2024 5:31:08 PM: TUF Brightness = 128 : OK
8/13/2024 5:31:09 PM: WMI event 199
8/13/2024 5:31:09 PM: TUF Brightness = 129 : OK
8/13/2024 5:31:09 PM: WMI event 199
8/13/2024 5:31:09 PM: TUF Brightness = 130 : OK
8/13/2024 5:31:09 PM: WMI event 199
8/13/2024 5:31:09 PM: TUF Brightness = 131 : OK

While backlight modes are absent

8/13/2024 5:30:27 PM: AuraMode: AuraStatic
8/13/2024 5:30:27 PM: TUF RGB = B4-00-FF-80-40-EB : 0 <-- 0 means it's not there
8/13/2024 5:30:27 PM: TUF RGB = B4-00-FF-80-40-EB : 0

What happens if you start asus services, does the backlight mode selection in G-Helper itself start suddenly working ? Or how do you change backlight otherwise ?

@seerge seerge added the question Further information is requested label Aug 13, 2024
@Rooie100
Copy link
Author

Rooie100 commented Aug 13, 2024 via email

@seerge
Copy link
Owner

seerge commented Aug 13, 2024

@Rooie100 then it looks like your device is quite unique and asus services work as a proxy between actual backlight and apps that want to set it, since when they are running all backlight commands work in g-helper.

It may be very difficult to find a way to directly set backlight in your case without having access to the actual device.

Can you make a DSDT dump as explained in Method 2 and upload it here ?

@seerge
Copy link
Owner

seerge commented Aug 15, 2024

@Rooie100 any updates with the dump here ?

@GDisco0730
Copy link

I have this same issue with Asus ProArt P16. When Ghelper is running amd Asus service are stopped, I am unable to change backlight color, modes, or brightness just nothing happens at all when any changes made. Even when I restart services, I am now able to change backlight brightness and modes, but still not the colors.

@seerge
Copy link
Owner

seerge commented Aug 15, 2024

@GDisco0730 does your device even support different colors? Cause Proart X13 does not for example.

As for the rest, same question please upload DSDT dump from Method 2 here (and log from the app as well)

@Rooie100
Copy link
Author

Hey Seerge,

Sorry to keep you waiting, i attached the dsdt in ZIP form/
dsdt.zip

@seerge
Copy link
Owner

seerge commented Aug 15, 2024

@Rooie100 hello, thanks.

Can you check if this build makes any difference ?
GHelper.zip

@gbassani
Copy link

gbassani commented Aug 15, 2024

I have the same issues with the vivobook s 16. Testing the new zip you added.

So far, the colors are now indexing again like it was new, constantly cycling through the colors (was just static blue prior).

I have my Asus uninstalled as well as having run the armoury crate removal tool.

Edit: Just to clarify, even with changing the color mode and/or color, the observed behavior remains with color cycle.

@seerge
Copy link
Owner

seerge commented Aug 15, 2024

@gbassani i don't think that you are similar to other people here :) as they can't control backlight (due to some unknown method specific only to that devices?)

If you had static blue - that's a sign of windows Dynamic Lighting being ON and taking over. Just make sure to disable it and regular mainstream build should work fine.

@gbassani
Copy link

Thank you for the info, missed that in the FAQ's. Even with dynamic lighting off (both globally and under the keyboard), the colors continue to cycle. I also tried setting both the personalization color and within G-Helper to static red. This is under the mainstream build.

Model is the M5606WA with the AMD stack. Also checked and it isn't in the list of compatible devices, I can submit for it there.

@seerge
Copy link
Owner

seerge commented Aug 15, 2024

@gbassani

  • How do you control backlight there in a first place w/o g-helper ?
  • You are saying that you have run AC uninstaller, but since it's not ROG or TUF you never had AC ?
  • Can you upload a log form the app?

@Rooie100
Copy link
Author

@Rooie100 hello, thanks.

Can you check if this build makes any difference ? GHelper.zip

Hey,

It semi fixed it! I can control the brightness now, but not the color. It stays in breathing mode....

@seerge
Copy link
Owner

seerge commented Aug 15, 2024

@Rooie100 ok, good news, can you try this build and post a log from it ?

GHelper.zip

@seerge
Copy link
Owner

seerge commented Aug 15, 2024

P.S. @gbassani @GDisco0730 you both can try build above as well

@Rooie100
Copy link
Author

Hi,

Here is the log! Thanks for the effort already, i'm happy that i can change the brightness at least.

log.txt

@seerge
Copy link
Owner

seerge commented Aug 16, 2024

@Rooie100 ok, but do backlight modes work in this build or not ?

@seerge
Copy link
Owner

seerge commented Aug 16, 2024

Cause if it does not, it looks like not only endpoint (i.e. where to set backlight setting) but also structure of the command itself is different.

Try this build instead, to see if it makes any difference (and again post a log)
GHelper.zip

@seerge
Copy link
Owner

seerge commented Aug 16, 2024

If even that build does not work, it means we need to monitor actual commands Asus Services send to hardware in order to change backlight modes

I have a guide on how to do that
https://github.com/seerge/g-helper/wiki/_ACPI-Monitoring-and-Debugging

@Rooie100
Copy link
Author

Hi,

Last build does not change a thing, can't change the lightning withing G-helper.
Log is attached, thanks for the response again!
log.txt

@seerge
Copy link
Owner

seerge commented Aug 17, 2024

@Rooie100 ok, thanks for checking.

Then the only way would be to intercept actual payloads that Asus service sends to the device in order to set backlight modes as explained in https://github.com/seerge/g-helper/wiki/_ACPI-Monitoring-and-Debugging

You will need to follow the guide, and then change backlight using Asus software (not G-Helper!) and record payloads

Ideally would be good to :

  • set different modes (but keep same color) and capture that.
  • then keep same mode but change colors and capture that as well :)

@kennycoder
Copy link

Try deleting %AppData%/GHelper folder. Fixed it for me. Unfortunately I didn't it backup up so I couldn't do the diff.
Anyone still experiencing issues, please do it and see what's the difference... will be helpful.
Mine is G14 from 2023.

@seerge
Copy link
Owner

seerge commented Aug 18, 2024

@kennycoder G14 2023 backlight control is 100% supported (and used by dozens of thousands of people). Config removal won't do anything except erasing of own G-Helper settings.

People in this thread have new (mid 2024 devices) that use different backlight controls.

@gbassani
Copy link

gbassani commented Aug 19, 2024

P.S. @gbassani @GDisco0730 you both can try build above as well

Apologies for delay, tried the latest zip package above from 3 days ago and still stuck on static white. Dynamic is disabled globally and at keyboard level. Also attempted to set to static red in personalization and in g-helper.

Attached the log.txt, screenshots of the dynamic lighting/g-helper, and the dsdt
log.txt

dsdt.zip

screenshots.zip

Edit: clarified about package used
Edit2: Previously I changed it through the dynamic lighting having it match the accent colors of the current window. I ran the uninstaller as that was in the readme and as this is my first Asus laptop, was not sure what AC components may or may not have been pre-installed. I had also removed the my Asus app.

@seerge
Copy link
Owner

seerge commented Aug 19, 2024

@gbassani hello, thanks for checking. As I have explained in a comment above i need someone to record actual payloads asus service sends to the device. As new Vivobooks seem to use different protocol completely :)

@seerge
Copy link
Owner

seerge commented Aug 20, 2024

@Rooie100 any updates here ? :)

@gbassani
Copy link

gbassani commented Aug 20, 2024

@gbassani hello, thanks for checking. As I have explained in a comment above i need someone to record actual payloads asus service sends to the device. As new Vivobooks seem to use different protocol completely :)

Working on this--spinning up a sandboxed installation. I'll use that tool after clean install prior to installing MyAsus to use the windows dynamic lighting and then will try after installing MyAsus for a second file. Command Interface v3 will be installed for both prior.

Edit: do you want me to also try capturing for this AsusKeyboard driver?
image

The attached is all I was able to generate over several minutes when clicking through the colors as well as the lighting types.
test.log

@seerge
Copy link
Owner

seerge commented Aug 21, 2024

@gbassani hello, thanks.

Your log contains only 2 commands, just for toggling backlight brightness, but both of them are already in G-Helper since the very beginning (and as I understand it works for you anyway)

0x0050021 -> 0x03 ON
0x0050021 -> 0x83 OFF

What I need is a payloads for changing backlight modes using Asus software :)

@seerge
Copy link
Owner

seerge commented Aug 21, 2024

@gbassani it's a free trial, just click download. You don't need to pay anything of course

@lazer15
Copy link

lazer15 commented Aug 21, 2024

@seerge
I have rebooted after installing the monitor tool. Asus services haven't been run yet. They are stopped. I am on step 2. The keyboard is currently blinking. I don't see a matching device id or name?
DeviceIdmissing

@seerge
Copy link
Owner

seerge commented Aug 21, 2024

@lazer15 that's quite strange, as usb device is 100% there (g-helper can see it). May be try to reboot ? :|

@lazer15
Copy link

lazer15 commented Aug 21, 2024

@seerge
It is actually that ITE device. I just found how to get the device id information to appear. It matches step 1's id.
Found

Blink_service_start.zip

@seerge
Copy link
Owner

seerge commented Aug 22, 2024

@lazer15 ok, great!

There is indeed some new init commands there

Try this build (and post a log)
GHelper.zip

seerge added a commit that referenced this issue Aug 22, 2024
@lazer15
Copy link

lazer15 commented Aug 22, 2024

@seerge
After rebooting it continues to be stuck on the breathing pattern.
log_init.zip

@seerge
Copy link
Owner

seerge commented Aug 22, 2024

@lazer15 hmm, strange. I have copied full payload from your capture now, try this build

GHelper.zip

@lazer15
Copy link

lazer15 commented Aug 22, 2024

@seerge
Tried the new one. Same issue.
loginit2.zip

It seems I need to click the mode button in g-helper after a reboot in order for that profile to apply. It will have silent mode selected when I open g-helper after a reboot but it doesn't actually seem to apply it (processor temp rises like it isn't in silent mode and fans come on) until I click silent mode myself. I do not know if that's at all potentially related to initialization of the keyboard. To me it seems like it isn't apply setting on boot at least for the performance mode.

Also is it normal for the battery to slowly creep up from 80%? It was 80% earlier (set the 80% charge limit) but it's now 81.2%. It was sleeping. It is charging with the stock charger. Since I've had the laptop and ghelper, it seems the battery level creeps past 80% even when windows is reporting smart battery charging mode. I've never had a laptop that supported the windows smart charge feature. It would creep up with asus services running or without. Never seemed to stay exactly at 80%.

@seerge
Copy link
Owner

seerge commented Aug 22, 2024

@lazer15 ok, one more attempt
GHelper.zip

As for your other questions.

  • Mode is always applied on app start. When you click mode again - it applied again.
  • Battery limiter resets on reboot, and is applied when app starts. It's normal that battery will be charging during boot + windows logon

@lazer15
Copy link

lazer15 commented Aug 22, 2024

@seerge
No luck with that build.
log3.zip

I can try capturing it again?

@seerge
Copy link
Owner

seerge commented Aug 22, 2024

@lazer15 from the log it looks like you

  1. Start "new" build first (it sends all init commands)
  2. Reboot
  3. On windows start old build starts (cause startup task still points to old exe) and it doesn't send init commands cause they are not there

Can either replace your usual GHelper.exe with a new build, or just run a new build from any location - but uncheck and check "Run on startup" ? (it will re-create startup task pointing to that exe)

@lazer15
Copy link

lazer15 commented Aug 22, 2024

@seerge
That was the issue. I didn't realize I should have been unchecking run at startup when switching between test versions.

My mistake:
I had been quitting (with run at startup still checked) -> launching the new test version -> ensure run at startup was checked -> restart computer -> check if keyboard is still breathing -> push backlight buttons -> get log.

Changed to:
Uncheck g-helper run at startup -> quit g-helper -> launch new g-helper -> check run at startup -> uncheck run at startup -> quit g-helper -> restart g-helper -> check run at startup -> reboot computer -> get log

I cleared the log for this retest the EXEs from today.

@lazer15 ok, one more attempt GHelper.zip

As for your other questions.

* Mode is always applied on app start. When you click mode again - it applied again.

* Battery limiter resets on reboot, and is applied when app starts. It's normal that battery will be charging during boot + windows logon

The latest version works.
loglatest.zip

@lazer15 hmm, strange. I have copied full payload from your capture now, try this build

GHelper.zip

I also just retested this one. This one doesn't work. Stuck with the breathing pattern.
Here's a log.
log init 2.zip

@lazer15 ok, great!

There is indeed some new init commands there

Try this build (and post a log) GHelper.zip

Here is a log from retesting the first one from today:
log init 1.zip
That one works.

Should I use the latest one or the 1st one from today? Is one preferable to the other?

@seerge
Copy link
Owner

seerge commented Aug 22, 2024

@lazer15 ok, great! To keep it simple - when you use latest version all the time - everything works as it should?

@lazer15
Copy link

lazer15 commented Aug 22, 2024

@seerge
Yes the latest works fine. Should I use that one? I am not sure if the 1st one is preferable for some reason. "init 3" is the latest one. "init 1" was the 1st one I tried today.

GHelper init 1.zip

GHelper init 3.zip

@seerge
Copy link
Owner

seerge commented Aug 22, 2024

@lazer15 no, you don't need to test old ones. Last one is definitely correct :)


Ssince you are already can record USB. Can you try to capture one more payload (not related to backlight but to FN-Lock)

  1. Start all asus services
  2. Quit G-Helper
  3. Capture what asus services send to keyboard when you press FN + ESC (that toggles hardware fn-lock on your device) ?

seerge added a commit that referenced this issue Aug 22, 2024
@lazer15
Copy link

lazer15 commented Aug 22, 2024

@seerge
Do you want me to reboot the computer prior to pressing FN + ESC? Or does that not matter here?

@seerge
Copy link
Owner

seerge commented Aug 22, 2024

@lazer15 it doesn't matter

@lazer15
Copy link

lazer15 commented Aug 22, 2024

@seerge
Here you go. FN+ESC is hardware fn-lock on the this device.
FN_esc.zip

On the P16 the brightness, volume ect functions are the default action when pressing F# keys. You have to press FN if you want to use those keys as F1, F2 ect. But I believe that's common on a lot of laptops now, defaulting to actions instead of F#. It was the same on my last 2 laptops a lenovo and a dell xps.

@seerge
Copy link
Owner

seerge commented Aug 23, 2024

@lazer15 ok, amazing.

Apparently part of "init" payload you recorded before was setting FN-lock OFF on device start (logical). So I have cleaned up "init" from that and also added hardware fn-lock handling in g-helper (before it was software imitation as app can do for any other device that doesn't have native fn-lock)

Can you try this build w/o any asus services and check if

  • FN lock works fine
  • You can still reboot and backlight controls still work fine ?

GHelper.zip

@lazer15
Copy link

lazer15 commented Aug 23, 2024

@seerge
FN-Lock works with that new version. Backlight keys also fine.

On the prior version I was able to toggle FN-Lock on and off without issue. On reboot it would default back to FN-Lock OFF which matches up with what you described the payload said. I thought that was normal because a dell XPS I used to have did the same.

Here's a log if needed:
logFN_Lock.zip

@seerge
Copy link
Owner

seerge commented Aug 23, 2024

@lazer15 ok, amazing

In "old" versions FN-lock was imitated on software level. There is a downside that when it's ON and you press FN+F1 for example, it would still emit special function (mute).

In "new" version FN-lock is handled by hardware (g-helper is not involved). So I assume when it's ON an you press FN+F1 it should just emit regular F1 key.

And thanks for testing :)

@lazer15
Copy link

lazer15 commented Aug 23, 2024

@seerge
Great, thanks for the updates to support this model👍

Do you know how to uninstall irpmon? When I ran the uninstaller, it said the uninstall was incomplete and components would need to be removed manually. It didn't say which components were left behind though. Maybe you've tried to uninstall it before after testing at some point?

@seerge
Copy link
Owner

seerge commented Aug 23, 2024

@lazer15 i think that's enough. At least I did same, also got same message and never had any issues after (including gaming). And I couldn't find any leftovers from irpmon neither anyway.

You can enable back secure boot if you want after :)

Btw in latest builds I have also added an option to udnervolt Ryzen 9 AI (migrated latest changes from the UXTU library that g-helper uses under the hood for undervolting), so if are interested you can test if it works as well.

@lazer15
Copy link

lazer15 commented Aug 23, 2024

@seerge
I see so it wasn't just me with that incomplete uninstall error. That's all I was trying to check. That's good. Yeah I put secure boot back on after uninstalling.

Sure I can try the new changes. I assumed that tab wasn't present in g-helper for me because maybe the proart line doesn't support it despite having the same processor as G14/G16. I was trying to improve battery life so some undervolting would be good.

@seerge
Copy link
Owner

seerge commented Aug 23, 2024

Ok,

To summarize all changes a result of this thread

  • New Vivobooks like M5506NA (@Rooie100) and M5606WA (@gbassani) should now support backlight brightness controls via the app with new ACPI endpoint. Backlight colors can't be changed neither via asus apps nor via G-Helper as they are exclusively controlled by new windows Dynamic Lighting

  • ProArt P16 (@lazer15) and ProArt X13 should support backlight brightness controls and backlight initialization on boot with new USB commands. And also hardware FN-Lock toggle for all ProArt devices should work properly.

Therefore closing as resolved. Thanks everyone for testing and information!

@seerge seerge closed this as completed Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

7 participants