Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #43

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Fix typos #43

merged 6 commits into from
Apr 2, 2024

Conversation

pitmonticone
Copy link
Contributor

No description provided.

@sefffal
Copy link
Owner

sefffal commented Mar 28, 2024

Hi @pitmonticone, I appreciate the proofread. However, I your changes (all but one) are changing the dialect from Canada/US English to UK English. Visualization is perfectly correct, and I see no reason to alter things to dialect that is not my own.

@pitmonticone
Copy link
Contributor Author

pitmonticone commented Mar 28, 2024

Hi @sefffal, thanks for your review, but I believe I've just changed "viZualiZation" to "viSualiZation".

@sefffal
Copy link
Owner

sefffal commented Mar 28, 2024

Oops, thanks for the clarification. Yes, I will gladly merge this with viZualiZation corrected to viSualiZation.

@pitmonticone
Copy link
Contributor Author

pitmonticone commented Mar 29, 2024

@sefffal I wrote it incorrectly in the comment. I pushed it correctly.

@sefffal sefffal merged commit 2f846a9 into sefffal:master Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants