Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix inconsistent error reporting between commit and generate functions #7

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

segersniels
Copy link
Owner

Description

Improves error handling and consistency across the application by refactoring model types and error reporting.

Added

  • New Model type to enforce type safety for model selection
  • Better error messaging for git commit failures

Changed

  • Refactored model constants to use the new Model type
  • Updated Claude model version to use latest tag
  • Improved error handling in the message generation process
  • Consolidated variables under a single var block
  • Simplified the commit flow by reusing the Generate() function

Fixed

  • Inconsistent error handling in git commit process by including command output in error messages
  • Generation errors now properly reported instead of being silently ignored
  • Proper model version handling for Claude 3.5 Sonnet

Removed

  • Duplicate code in Commit() function by leveraging existing Generate() function

@segersniels segersniels self-assigned this Nov 18, 2024
@segersniels segersniels merged commit 7a1e60f into master Nov 18, 2024
1 of 2 checks passed
@segersniels segersniels deleted the fix/inconsistent-request-errors branch November 18, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

genmoji generate doesn't print network errors, but genmoji commit does.
1 participant