Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid off dbus_proxy warning about defaults #8

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

pnevyk
Copy link
Contributor

@pnevyk pnevyk commented Nov 28, 2022

zbus introduced assume_defaults attribute for dbus_proxy macro in version 3.5.0. They also started to print a warning if neither of assume_defaults/default_path/default_service were specified, which for keepawake looked like this:

#[dbus_proxy(...)] macro invocation on 'ScreenSaverProxyBlocking' without explicit defaults. Please set 'assume_defaults = true', or configure default path/service directly.
#[dbus_proxy(...)] macro invocation on 'ScreenSaverProxy' without explicit defaults. Please set 'assume_defaults = true', or configure default path/service directly.

This PR updates the zbus dependency to 3.5.0 and sets assume_defaults = true which is, according to docs, the current default. Hence the warning is gone.

@segevfiner segevfiner merged commit 7519308 into segevfiner:main Nov 29, 2022
@pnevyk pnevyk deleted the remove-dbus-proxy-warning branch November 30, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants