Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return updated refresh token so that it can be saved #1476

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

sorich87
Copy link
Contributor

@sorich87 sorich87 commented Aug 8, 2023

This PR updates Hilo Destination refreshAccessToken method return value to include a new refreshToken, so that it can be stored on the Segment side.

Inspired by #1111 which does the same for Blackbaud Raiser's Edge NXT Destination.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

@sorich87 sorich87 requested a review from a team as a code owner August 8, 2023 10:56
@sorich87 sorich87 requested a review from a team August 8, 2023 10:56
@sorich87 sorich87 mentioned this pull request Aug 8, 2023
3 tasks
@joe-ayoub-segment joe-ayoub-segment self-assigned this Aug 8, 2023
@joe-ayoub-segment
Copy link
Contributor

Hi @sorich87 ,
There's a flakey test from another Integration which is causing this PR to fail CI.
The test has now been fixed, but you will need to get the latest code from main before this PR will pass CI.
Can you do this please?
Best regards,
Joe

@sorich87
Copy link
Contributor Author

sorich87 commented Aug 8, 2023

Thanks @joe-ayoub-segment! I updated it.

@sorich87
Copy link
Contributor Author

sorich87 commented Aug 8, 2023

@joe-ayoub-segment I see it's still failing. Is there something else I need to do?

@joe-ayoub-segment
Copy link
Contributor

Looks like a test from another Integration is failing. I'll look into it now.

@joe-ayoub-segment
Copy link
Contributor

Hi @sorich87 can you try getting latest files please (again)?

@sorich87
Copy link
Contributor Author

sorich87 commented Aug 8, 2023

@joe-ayoub-segment done

@joe-ayoub-segment joe-ayoub-segment merged commit 1c03fc8 into segmentio:main Aug 8, 2023
@joe-ayoub-segment
Copy link
Contributor

Hi @sorich87 this PR has been deployed. Please let me know how testing goes!

@sorich87
Copy link
Contributor Author

Thanks, @joe-ayoub-segment! For some reason, it's still not working. I'm looking into it on our end but it's hard to test. Let me know if you have any ideas.

@joe-ayoub-segment
Copy link
Contributor

hi @sorich87 , can you schedule a call with me so we can look at this together please?
http://calendly.com/joe_ayoub/integration-workshop

Best regards,
Joe

@sorich87
Copy link
Contributor Author

@joe-ayoub-segment done! Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants